Copilot comments

Author: tpellissier

examples/advanced/file_upload.py

@@ -187,7 +187,7 @@ def ensure_table():
     sys.exit(1)
 
 entity_set = table_info.get("entity_set_name")
-table_schema_name = table_info.get("entity_schema_name") or entity_set.rstrip("s")
+table_schema_name = table_info.get("table_schema_name") or entity_set.rstrip("s")
 attr_prefix = table_schema_name.split('_',1)[0] if '_' in table_schema_name else table_schema_name
 name_attr = f"{attr_prefix}_name"
 small_file_attr_schema = f"{attr_prefix}_SmallDocument"  # second file attribute for small single-request demo

examples/advanced/pandas_integration.py

@@ -74,10 +74,10 @@ def backoff_retry(op, *, delays=(0, 2, 5, 10, 20), retry_http_statuses=(400, 403
 	table_info = existing
 	created_this_run = False
 	print({
-		"table": table_info.get("entity_schema"),
+		"table": table_info.get("table_schema_name"),
 		"existed": True,
 		"entity_set": table_info.get("entity_set_name"),
-		"logical": table_info.get("entity_logical_name"),
+		"logical": table_info.get("table_logical_name"),
 		"metadata_id": table_info.get("metadata_id"),
 	})
 
@@ -96,10 +96,10 @@ def backoff_retry(op, *, delays=(0, 2, 5, 10, 20), retry_http_statuses=(400, 403
 		)
 		created_this_run = True if table_info and table_info.get("columns_created") else False
 		print({
-			"table": table_info.get("entity_schema") if table_info else None,
+			"table": table_info.get("table_schema_name") if table_info else None,
 			"existed": False,
 			"entity_set": table_info.get("entity_set_name") if table_info else None,
-			"logical": table_info.get("entity_logical_name") if table_info else None,
+			"logical": table_info.get("table_logical_name") if table_info else None,
 			"metadata_id": table_info.get("metadata_id") if table_info else None,
 		})
 	except Exception as e:
@@ -119,7 +119,7 @@ def backoff_retry(op, *, delays=(0, 2, 5, 10, 20), retry_http_statuses=(400, 403
 		# Fail fast: all operations must use the custom table
 		sys.exit(1)
 
-logical = table_info.get("entity_logical_name")
+logical = table_info.get("table_logical_name")
 # Derive attribute logical name prefix from the entity logical name
 attr_prefix = logical.split("_", 1)[0] if "_" in logical else logical
 record_data = {

examples/advanced/walkthrough.py

@@ -75,8 +75,8 @@ def main():
     table_info = client.get_table_info(table_name)
 
     if table_info:
-        print(f"✓ Table already exists: {table_info.get('entity_schema')}")
-        print(f"  Logical Name: {table_info.get('entity_logical_name')}")
+        print(f"✓ Table already exists: {table_info.get('table_schema_name')}")
+        print(f"  Logical Name: {table_info.get('table_logical_name')}")
         print(f"  Entity Set: {table_info.get('entity_set_name')}")
     else:
         log_call(f"client.create_table('{table_name}', schema={{...}})")
@@ -88,7 +88,7 @@ def main():
             "new_Priority": Priority
         }
         table_info = client.create_table(table_name, schema)
-        print(f"✓ Created table: {table_info.get('entity_schema')}")
+        print(f"✓ Created table: {table_info.get('table_schema_name')}")
         print(f"  Columns created: {', '.join(table_info.get('columns_created', []))}")
 
     # ============================================================================

examples/basic/functional_testing.py

@@ -106,8 +106,8 @@ def ensure_test_table(client: DataverseClient) -> Dict[str, Any]:
             }
         )
 
-        print(f"✅ Created test table: {table_info.get('entity_schema')}")
-        print(f"   Logical name: {table_info.get('entity_logical_name')}")
+        print(f"✅ Created test table: {table_info.get('table_schema_name')}")
+        print(f"   Logical name: {table_info.get('table_logical_name')}")
         print(f"   Entity set: {table_info.get('entity_set_name')}")
 
         # Wait a moment for table to be ready
@@ -124,7 +124,7 @@ def test_create_record(client: DataverseClient, table_info: Dict[str, Any]) -> s
     print("\n📝 Record Creation Test")
     print("=" * 50)
 
-    logical_name = table_info.get("entity_logical_name")
+    logical_name = table_info.get("table_logical_name")
     attr_prefix = logical_name.split("_", 1)[0] if "_" in logical_name else logical_name
 
     # Create test record data
@@ -163,7 +163,7 @@ def test_read_record(client: DataverseClient, table_info: Dict[str, Any], record
     print("\n📖 Record Reading Test")
     print("=" * 50)
 
-    logical_name = table_info.get("entity_logical_name")
+    logical_name = table_info.get("table_logical_name")
     attr_prefix = logical_name.split("_", 1)[0] if "_" in logical_name else logical_name
 
     try:
@@ -198,7 +198,7 @@ def test_query_records(client: DataverseClient, table_info: Dict[str, Any]) -> N
     print("\n🔍 Record Query Test")
     print("=" * 50)
 
-    logical_name = table_info.get("entity_logical_name")
+    logical_name = table_info.get("table_logical_name")
     attr_prefix = logical_name.split("_", 1)[0] if "_" in logical_name else logical_name
 
     try:
@@ -234,7 +234,7 @@ def cleanup_test_data(client: DataverseClient, table_info: Dict[str, Any], recor
     print("\n🧹 Cleanup")
     print("=" * 50)
 
-    logical_name = table_info.get("entity_logical_name")
+    logical_name = table_info.get("table_logical_name")
 
     # Ask user if they want to clean up
     cleanup_choice = input("Do you want to delete the test record? (y/N): ").strip().lower()
@@ -253,7 +253,7 @@ def cleanup_test_data(client: DataverseClient, table_info: Dict[str, Any], recor
 
     if table_cleanup in ['y', 'yes']:
         try:
-            client.delete_table(table_info.get("entity_schema"))
+            client.delete_table(table_info.get("table_schema_name"))
             print("✅ Test table deleted successfully")
         except Exception as e:
             print(f"⚠️  Failed to delete test table: {e}")

examples/basic/installation_example.py

@@ -226,7 +226,7 @@ def show_usage_examples():
 
 # Get table information
 info = client.get_table_info("CustomEntity")
-print(f"Table: {info['entity_schema']}")
+print(f"Table: {info['table_schema_name']}")
 
 # List all tables
 tables = client.list_tables()

src/PowerPlatform/Dataverse/client.py

@@ -402,8 +402,8 @@ def get_table_info(self, table_schema_name: str) -> Optional[Dict[str, Any]]:
         :param table_schema_name: Table schema name (e.g. ``"new_SampleItem"`` or ``"account"``).
         :type table_schema_name: str
 
-        :return: Dictionary containing table metadata with keys ``entity_schema``,
-            ``entity_logical_name``, ``entity_set_name``, and ``metadata_id``.
+        :return: Dictionary containing table metadata with keys ``table_schema_name``,
+            ``table_logical_name``, ``entity_set_name``, and ``metadata_id``.
             Returns None if the table is not found.
         :rtype: dict or None
 
@@ -412,7 +412,7 @@ def get_table_info(self, table_schema_name: str) -> Optional[Dict[str, Any]]:
 
                 info = client.get_table_info("new_SampleItem")
                 if info:
-                    print(f"Logical name: {info['entity_logical_name']}")
+                    print(f"Logical name: {info['table_logical_name']}")
                     print(f"Entity set: {info['entity_set_name']}")
         """
         return self._get_odata()._get_table_info(table_schema_name)
@@ -454,8 +454,8 @@ class ItemStatus(IntEnum):
             from the table's customization prefix value.
         :type primary_column_schema_name: str or None
 
-        :return: Dictionary containing table metadata including ``entity_schema``,
-            ``entity_set_name``, ``entity_logical_name``, ``metadata_id``, and ``columns_created``.
+        :return: Dictionary containing table metadata including ``table_schema_name``,
+            ``entity_set_name``, ``table_logical_name``, ``metadata_id``, and ``columns_created``.
         :rtype: dict
 
         :raises ~PowerPlatform.Dataverse.core.errors.MetadataError: If table creation fails or the schema is invalid.
@@ -478,7 +478,7 @@ class ItemStatus(IntEnum):
                 }
 
                 result = client.create_table("new_SampleItem", schema)
-                print(f"Created table: {result['entity_logical_name']}")
+                print(f"Created table: {result['table_logical_name']}")
                 print(f"Columns: {result['columns_created']}")
 
             Create a table with a custom primary column name::

src/PowerPlatform/Dataverse/data/odata.py

@@ -571,7 +571,7 @@ def _do_request(url: str, *, params: Optional[Dict[str, Any]] = None) -> Dict[st
             params["$orderby"] = ",".join(self._lowercase_list(orderby))
         if expand:
             # Lowercase navigation property names for case-insensitive matching
-            params["$expand"] = ",".join(self._lowercase_list(expand))
+            params["$expand"] = ",".join(expand)
         if top is not None:
             params["$top"] = int(top)
 
@@ -1175,8 +1175,8 @@ def _get_table_info(self, table_schema_name: str) -> Optional[Dict[str, Any]]:
         if not ent:
             return None
         return {
-            "entity_schema": ent.get("SchemaName") or table_schema_name,
-            "entity_logical_name": ent.get("LogicalName"),
+            "table_schema_name": ent.get("SchemaName") or table_schema_name,
+            "table_logical_name": ent.get("LogicalName"),
             "entity_set_name": ent.get("EntitySetName"),
             "metadata_id": ent.get("MetadataId"),
             "columns_created": [],
@@ -1254,8 +1254,8 @@ def _create_table(
         )
 
         return {
-            "entity_schema": table_schema_name,
-            "entity_logical_name": metadata.get("LogicalName"),
+            "table_schema_name": table_schema_name,
+            "table_logical_name": metadata.get("LogicalName"),
             "entity_set_name": metadata.get("EntitySetName"),
             "metadata_id": metadata.get("MetadataId"),
             "columns_created": created_cols,
@@ -1277,8 +1277,6 @@ def _create_columns(
                 subcode=ec.METADATA_TABLE_NOT_FOUND,
             )
 
-        # Use the actual SchemaName from the entity metadata
-        entity_schema = ent.get("SchemaName") or table_schema_name
         metadata_id = ent.get("MetadataId")
         created: List[str] = []
         needs_picklist_flush = False