remove feature flag

Author: Max Wang

README.md

@@ -335,45 +335,6 @@ VS Code Tasks
 - Install deps: `Install deps (pip)`
 - Run example: `Run Quickstart (Dataverse SDK)`
 
-
-## Feature Flags (extensible) & Picklist Label Coercion
-
-The SDK uses a lightweight feature flag system.
-
-Source & schema:
-`feature_flags.json` (packaged) provides defaults. Each feature MUST use the strict object form only:
-
-```json
-{
-  "flag_name": {
-    "default": false,
-    "description": "Human readable explanation of the flag purpose"
-  }
-}
-```
-
-Notes:
-- Both `default` (bool) and `description` (non-empty string) are required.
-- No extra keys are allowed (startup fails fast on unknown keys).
-- The JSON file does NOT accept boolean shorthand; that form is permitted only for runtime overrides passed to the client.
-
-Override a feature flag mapping at construction:
-```python
-client = DataverseClient(
-	base_url="https://yourorg.crm.dynamics.com",
-	feature_flags={
-		"option_set_label_conversion": True,
-	}
-)
-```
-
-Toggle/check at runtime:
-```python
-client.enable_feature("option_set_label_conversion")
-client.is_feature_enabled("option_set_label_conversion")
-client.disable_feature("option_set_label_conversion")
-```
-
 ## Limitations / Future Work
 - No general-purpose OData batching, upsert, or association operations yet.
 - `DeleteMultiple` not yet exposed.

src/dataverse_sdk/client.py

@@ -42,15 +42,13 @@ def __init__(
         base_url: str,
         credential: Optional[TokenCredential] = None,
         config: Optional[DataverseConfig] = None,
-        feature_flags: Optional[Dict[str, bool]] = None,
     ) -> None:
         self.auth = AuthManager(credential)
         self._base_url = (base_url or "").rstrip("/")
         if not self._base_url:
             raise ValueError("base_url is required.")
         self._config = config or DataverseConfig.from_env()
         self._odata: Optional[ODataClient] = None
-        self._feature_flags = dict(feature_flags) if isinstance(feature_flags, dict) else None
 
     def _get_odata(self) -> ODataClient:
         """Get or create the internal OData client instance.
@@ -65,7 +63,6 @@ def _get_odata(self) -> ODataClient:
                 self.auth,
                 self._base_url,
                 self._config,
-                feature_flags=self._feature_flags,
             )
         return self._odata
 
@@ -276,18 +273,5 @@ def flush_cache(self, kind) -> int:
         """
         return self._get_odata()._flush_cache(kind)
 
-    # ---------------------- Feature flags / toggles ----------------------
-    def set_feature(self, name: str, enabled: bool) -> None:
-        self._get_odata().set_feature(name, enabled)
-        
-    def enable_feature(self, name: str) -> None:
-        self.set_feature(name, True)
-
-    def disable_feature(self, name: str) -> None:
-        self.set_feature(name, False)
-
-    def is_feature_enabled(self, name: str) -> bool:
-        return self._get_odata().is_feature_enabled(name)
-
 __all__ = ["DataverseClient"]
 

src/dataverse_sdk/feature_flags.json

@@ -27,7 +27,6 @@ def __init__(
         auth,
         base_url: str,
         config=None,
-        feature_flags: Optional[Dict[str, bool]] = None,
     ) -> None:
         self.auth = auth
         self.base_url = (base_url or "").rstrip("/")
@@ -51,72 +50,6 @@ def __init__(
         # Picklist label cache: (logical_name, attribute_logical) -> {'map': {...}, 'ts': epoch_seconds}
         self._picklist_label_cache = {}
         self._picklist_cache_ttl_seconds = 3600  # 1 hour TTL
-        # Load required feature flags from bundled JSON resource; fail hard if missing or invalid.
-        try:
-            data = ir.files("dataverse_sdk").joinpath("feature_flags.json").read_text(encoding="utf-8")
-        except Exception as e:
-            raise RuntimeError(f"Failed to load feature_flags.json resource: {e}") from e
-        try:
-            loaded = json.loads(data) if data else {}
-        except Exception as e:
-            raise RuntimeError(f"feature_flags.json is not valid JSON: {e}") from e
-        if not isinstance(loaded, dict):
-            raise RuntimeError("feature_flags.json root must be a JSON object mapping feature -> (bool | object)")
-
-        self._features: Dict[str, bool] = {}
-        self._feature_metadata: Dict[str, Dict[str, Any]] = {}
-
-        for raw_key, raw_val in loaded.items():
-            # Enforce key type and non-empty constraint
-            if not isinstance(raw_key, str):
-                raise RuntimeError(f"feature_flags.json key '{raw_key}' is not a string")
-            key = raw_key.strip().lower()
-            if not key:
-                raise RuntimeError("feature_flags.json contains an empty feature name")
-            # Object form with strict schema: { "default": bool, "description": str }
-            if isinstance(raw_val, dict):
-                required_keys = {"default", "description"}
-                unknown = set(raw_val.keys()) - required_keys
-                if unknown:
-                    raise RuntimeError(
-                        f"Feature '{raw_key}' has unknown metadata keys: {', '.join(sorted(unknown))}. Allowed: default, description"
-                    )
-                missing = required_keys - set(raw_val.keys())
-                if missing:
-                    raise RuntimeError(
-                        f"Feature '{raw_key}' object missing required key(s): {', '.join(sorted(missing))} (requires: default, description)"
-                    )
-                if not isinstance(raw_val["default"], bool):
-                    raise RuntimeError(f"Feature '{raw_key}' field 'default' must be boolean")
-                desc = raw_val["description"]
-                if not isinstance(desc, str) or not desc.strip():
-                    raise RuntimeError(f"Feature '{raw_key}' field 'description' must be a non-empty string")
-                self._features[key] = raw_val["default"]
-                self._feature_metadata[key] = {"description": desc.strip()}
-                continue
-            # Any other type is invalid
-            raise RuntimeError(
-                f"Feature '{raw_key}' must be an object with 'default' (bool) and required 'description' (non-empty str)"
-            )
-
-        # Overlay user overrides (if supplied). Overrides must:
-        #   - use existing feature names declared in feature_flags.json
-        #   - provide boolean values only (no coercion of truthy/falsy non-bools)
-        #   - use non-empty string keys
-        if isinstance(feature_flags, dict):
-            for k, v in feature_flags.items():
-                if not isinstance(k, str) or not k.strip():
-                    raise ValueError("feature_flags override keys must be non-empty strings")
-                norm = k.strip().lower()
-                if norm not in self._features:
-                    raise ValueError(
-                        f"Unknown feature flag override '{k}' (not declared in feature_flags.json)"
-                    )
-                if not isinstance(v, bool):
-                    raise ValueError(
-                        f"Override value for feature '{k}' must be boolean (got {type(v).__name__})"
-                    )
-                self._features[norm] = v
 
     def _headers(self) -> Dict[str, str]:
         """Build standard OData headers with bearer auth."""
@@ -845,6 +778,10 @@ def _optionset_map(self, entity_set: str, attr_logical: str) -> Optional[Dict[st
 
         Returns empty dict if attribute is not a picklist or has no options. Returns None only
         for invalid inputs or unexpected metadata parse failures.
+
+        Notes
+        -----
+        - This method calls the Web API twice per attribute so it could have perf impact when there are lots of columns on the entity.
         """
         if not entity_set or not attr_logical:
             return None
@@ -944,9 +881,6 @@ def _convert_labels_to_ints(self, entity_set: str, record: Dict[str, Any]) -> Di
         Heuristic: For each string value, attempt to resolve against picklist metadata.
         If attribute isn't a picklist or label not found, value left unchanged.
         """
-        # Fast-path: feature disabled (default). Return original record without copy to avoid overhead.
-        if not self.is_feature_enabled("option_set_label_conversion"):
-            return record
         out = record.copy()
         for k, v in list(out.items()):
             if not isinstance(v, str) or not v.strip():
@@ -1150,21 +1084,4 @@ def _flush_cache(
 
         removed = len(self._picklist_label_cache)
         self._picklist_label_cache.clear()
-        return removed
-
-    # ---------------------- Feature flags / toggles --------------------
-    def set_feature(self, name: str, enabled: bool) -> None:
-        if not isinstance(name, str) or not name.strip():
-            raise ValueError("Feature name must be a non-empty string")
-        self._features[name.strip().lower()] = bool(enabled)
-
-    def enable_feature(self, name: str) -> None:
-        self.set_feature(name, True)
-
-    def disable_feature(self, name: str) -> None:
-        self.set_feature(name, False)
-
-    def is_feature_enabled(self, name: str) -> bool:
-        if not isinstance(name, str):
-            return False
-        return bool(self._features.get(name.strip().lower()))
+        return removed