test: review fixes and assertion strengthening

Author: Abel Milash

tests/unit/core/test_auth.py

@@ -14,8 +14,12 @@ class TestAuthManager(unittest.TestCase):
 
     def test_non_token_credential_raises(self):
         """_AuthManager raises TypeError when credential does not implement TokenCredential."""
-        with self.assertRaises(TypeError):
+        with self.assertRaises(TypeError) as ctx:
             _AuthManager("not-a-credential")
+        self.assertEqual(
+            str(ctx.exception),
+            "credential must implement azure.core.credentials.TokenCredential.",
+        )
 
     def test_acquire_token_returns_token_pair(self):
         """_acquire_token calls get_token and returns a _TokenPair with scope and token."""
@@ -29,4 +33,3 @@ def test_acquire_token_returns_token_pair(self):
         self.assertIsInstance(result, _TokenPair)
         self.assertEqual(result.resource, "https://org.crm.dynamics.com/.default")
         self.assertEqual(result.access_token, "my-access-token")
-

tests/unit/core/test_http_client.py

@@ -49,7 +49,7 @@ def test_default_timeout_overrides_per_method_default(self):
             _, kwargs = mock_req.call_args
             self.assertEqual(kwargs["timeout"], 30.0)
 
-    def test_explicit_timeout_in_kwargs_is_not_overridden(self):
+    def test_explicit_timeout_kwarg_takes_precedence(self):
         """If timeout is already in kwargs it is passed through unchanged."""
         client = _HttpClient(retries=1, timeout=30.0)
         with patch("requests.request", return_value=self._make_response()) as mock_req:
@@ -66,7 +66,7 @@ def _make_response(self):
         resp.status_code = 200
         return resp
 
-    def test_uses_requests_request_when_no_session(self):
+    def test_uses_direct_request_without_session(self):
         """Without a session, _request uses requests.request directly."""
         client = _HttpClient(retries=1)
         with patch("requests.request", return_value=self._make_response()) as mock_req:

tests/unit/core/test_http_errors.py

@@ -182,8 +182,6 @@ def test_correlation_id_shared_inside_call_scope():
     assert h1["x-ms-correlation-id"] == h2["x-ms-correlation-id"]
 
 
-# --- ValidationError / SQLParseError / HttpError optional fields ---
-
 def test_validation_error_instantiates():
     """ValidationError can be raised and carries the correct code."""
     from PowerPlatform.Dataverse.core.errors import ValidationError