Add coverage gap tests: timezone-aware timestamps, expand data, @OData stripping, whitespace IDs, multi-row NaN patterns

Author: Saurabh Badenkal

tests/unit/test_dataframe_operations.py

@@ -433,6 +433,54 @@ def test_create_normalizes_numpy_types_before_api(self):
         self.assertIsInstance(rec["createdon"], str)
         self.assertEqual(rec["createdon"], "2024-06-01T00:00:00")
 
+    def test_get_with_expand_includes_nested_data(self):
+        """get() with expand returns DataFrame including expanded navigation property data."""
+        page = [
+            {
+                "accountid": "guid-1",
+                "name": "Contoso",
+                "primarycontactid": {"contactid": "c-1", "fullname": "John"},
+            }
+        ]
+        self.client._odata._get_multiple.return_value = iter([page])
+        df = self.client.dataframe.get("account", expand=["primarycontactid"])
+        self.assertEqual(len(df), 1)
+        self.assertEqual(df.iloc[0]["name"], "Contoso")
+        self.assertIsInstance(df.iloc[0]["primarycontactid"], dict)
+        self.assertEqual(df.iloc[0]["primarycontactid"]["fullname"], "John")
+
+    def test_get_single_record_no_odata_keys(self):
+        """Single-record get strips @odata.* keys from the returned DataFrame."""
+        self.client._odata._get.return_value = {
+            "@odata.context": "https://example.crm.dynamics.com/$metadata#accounts/$entity",
+            "@odata.etag": 'W/"123"',
+            "accountid": "guid-1",
+            "name": "Contoso",
+        }
+        df = self.client.dataframe.get("account", record_id="guid-1")
+        self.assertNotIn("@odata.context", df.columns)
+        self.assertNotIn("@odata.etag", df.columns)
+        self.assertIn("name", df.columns)
+        self.assertEqual(df.iloc[0]["name"], "Contoso")
+
+    def test_delete_whitespace_only_ids_rejected(self):
+        """Series containing whitespace-only strings raises ValueError."""
+        ids = pd.Series(["guid-1", "   ", "guid-3"])
+        with self.assertRaises(ValueError) as ctx:
+            self.client.dataframe.delete("account", ids)
+        self.assertIn("invalid values", str(ctx.exception))
+        self.assertIn("[1]", str(ctx.exception))
+
+    def test_update_with_timezone_aware_timestamps(self):
+        """Update correctly normalizes timezone-aware Timestamps."""
+        ts = pd.Timestamp("2024-06-15 10:30:00", tz="UTC")
+        df = pd.DataFrame([{"accountid": "guid-1", "lastonholdtime": ts}])
+        self.client.dataframe.update("account", df, id_column="accountid")
+        call_args = self.client._odata._update.call_args[0]
+        changes = call_args[2]
+        self.assertIsInstance(changes["lastonholdtime"], str)
+        self.assertIn("2024-06-15T10:30:00", changes["lastonholdtime"])
+
 
 if __name__ == "__main__":
     unittest.main()

tests/unit/test_pandas_helpers.py

@@ -66,6 +66,25 @@ def test_none_passthrough(self):
         result = _normalize_scalar(None)
         self.assertIsNone(result)
 
+    def test_timestamp_with_timezone(self):
+        """Timezone-aware pd.Timestamp is converted to ISO 8601 with tz offset."""
+        ts = pd.Timestamp("2024-06-15 10:30:00", tz="UTC")
+        result = _normalize_scalar(ts)
+        self.assertIn("2024-06-15T10:30:00", result)
+        self.assertIsInstance(result, str)
+
+    def test_numpy_int32(self):
+        """np.int32 is also converted to Python int."""
+        result = _normalize_scalar(np.int32(7))
+        self.assertIsInstance(result, int)
+        self.assertEqual(result, 7)
+
+    def test_numpy_float32(self):
+        """np.float32 is also converted to Python float."""
+        result = _normalize_scalar(np.float32(2.5))
+        self.assertIsInstance(result, float)
+        self.assertAlmostEqual(result, 2.5, places=5)
+
 
 class TestDataframeToRecords(unittest.TestCase):
     """Unit tests for dataframe_to_records()."""
@@ -165,6 +184,40 @@ def test_mixed_types(self):
         self.assertEqual(rec["createdon"], "2024-06-01T00:00:00")
         self.assertNotIn("notes", rec)
 
+    def test_timezone_aware_timestamp(self):
+        """Timezone-aware Timestamp in DataFrame is converted to ISO string with tz."""
+        ts = pd.Timestamp("2024-06-15 10:30:00", tz="US/Eastern")
+        df = pd.DataFrame([{"createdon": ts}])
+        result = dataframe_to_records(df)
+        self.assertIn("2024-06-15T10:30:00", result[0]["createdon"])
+        self.assertIsInstance(result[0]["createdon"], str)
+
+    def test_multiple_rows_some_with_nan(self):
+        """Multi-row DataFrame with mixed NaN positions drops correct keys per row."""
+        df = pd.DataFrame(
+            [
+                {"name": "A", "phone": "555-0100", "city": None},
+                {"name": "B", "phone": None, "city": "Seattle"},
+                {"name": None, "phone": "555-0300", "city": "Portland"},
+            ]
+        )
+        result = dataframe_to_records(df)
+        self.assertEqual(result[0], {"name": "A", "phone": "555-0100"})
+        self.assertEqual(result[1], {"name": "B", "city": "Seattle"})
+        self.assertEqual(result[2], {"phone": "555-0300", "city": "Portland"})
+
+    def test_multiple_rows_na_as_null(self):
+        """Multi-row DataFrame with na_as_null=True includes None for all missing values."""
+        df = pd.DataFrame(
+            [
+                {"name": "A", "phone": None},
+                {"name": None, "phone": "555-0200"},
+            ]
+        )
+        result = dataframe_to_records(df, na_as_null=True)
+        self.assertEqual(result[0], {"name": "A", "phone": None})
+        self.assertEqual(result[1], {"name": None, "phone": "555-0200"})
+
 
 if __name__ == "__main__":
     unittest.main()