From 2dc177d50b308850aa204d0b93211041fb320b3b Mon Sep 17 00:00:00 2001
From: fei <204683769+feiiiiii5@users.noreply.github.com>
Date: Sat, 22 Aug 2026 22:56:39 +0800
Subject: [PATCH] FIX: distinguish catalog-unavailable from unregistered in
 Initializers page

When the registered-initializer catalog request fails transiently, the
Initializers page preserved configured baseline settings but described
valid entries as 'Initializer is no longer registered.' A temporary
metadata availability failure was therefore presented as a definitive
registration problem.

Track catalog fetch success/failure and pass the availability flag
through to BaselineInitializers / AdditionalInitializers so unresolved
names render 'Catalog metadata temporarily unavailable.' when only the
catalog request failed. Names genuinely absent from a successful catalog
response still show 'no longer registered.'

Fixes #2442

Signed-off-by: fei <204683769+feiiiiii5@users.noreply.github.com>
---
 .../Initializers/AdditionalInitializers.tsx    |  8 +++++++-
 .../Initializers/BaselineInitializers.tsx      |  8 +++++++-
 .../components/Initializers/Initializers.tsx   |  5 +++++
 .../Initializers/initializerLookup.test.ts     | 18 ++++++++++++++++++
 .../Initializers/initializerLookup.ts          | 11 +++++++++++
 5 files changed, 48 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/Initializers/AdditionalInitializers.tsx b/frontend/src/components/Initializers/AdditionalInitializers.tsx
index 992292ca3c..d3a278218b 100644
--- a/frontend/src/components/Initializers/AdditionalInitializers.tsx
+++ b/frontend/src/components/Initializers/AdditionalInitializers.tsx
@@ -25,6 +25,7 @@ import ConfirmDialog from '../ConfirmDialog'
 interface AdditionalInitializersProps {
   items: AdditionalInitializerSetting[]
   registeredInitializers: RegisteredInitializer[]
+  catalogUnavailable?: boolean
   creating: boolean
   savingInitializerId?: string | null
   saveErrors?: Record<string, string>
@@ -157,6 +158,7 @@ function AdditionalInitializerCard({
 export default function AdditionalInitializers({
   items,
   registeredInitializers,
+  catalogUnavailable,
   creating,
   savingInitializerId = null,
   saveErrors = {},
@@ -237,7 +239,11 @@ export default function AdditionalInitializers({
             <AdditionalInitializerCard
               key={`${item.id}:${formatInitializerParameters(item.parameters)}:${item.order_index ?? ''}`}
               item={item}
-              initializer={resolveRegisteredInitializer(item.initializer_name, registeredInitializers)}
+              initializer={resolveRegisteredInitializer(
+                item.initializer_name,
+                registeredInitializers,
+                catalogUnavailable,
+              )}
               isSaving={savingInitializerId === item.id}
               isApplying={applyingInitializerId === item.id}
               isDeleting={deletingInitializerId === item.id}
diff --git a/frontend/src/components/Initializers/BaselineInitializers.tsx b/frontend/src/components/Initializers/BaselineInitializers.tsx
index 46910182ff..4d82bf9f22 100644
--- a/frontend/src/components/Initializers/BaselineInitializers.tsx
+++ b/frontend/src/components/Initializers/BaselineInitializers.tsx
@@ -9,11 +9,13 @@ import { useInitializersStyles } from './Initializers.styles'
 interface BaselineInitializersProps {
   items: BaselineInitializerSetting[]
   registeredInitializers: RegisteredInitializer[]
+  catalogUnavailable?: boolean
 }
 
 export default function BaselineInitializers({
   items,
   registeredInitializers,
+  catalogUnavailable,
 }: BaselineInitializersProps) {
   const styles = useInitializersStyles()
 
@@ -32,7 +34,11 @@ export default function BaselineInitializers({
       ) : (
         <div className={styles.baselineGroup} role="list" aria-label="Baseline initializers">
           {items.map((item: BaselineInitializerSetting) => {
-            const initializer = resolveRegisteredInitializer(item.initializer_name, registeredInitializers)
+            const initializer = resolveRegisteredInitializer(
+              item.initializer_name,
+              registeredInitializers,
+              catalogUnavailable,
+            )
             return (
               <div
                 key={`${item.initializer_name}:${item.order_index}`}
diff --git a/frontend/src/components/Initializers/Initializers.tsx b/frontend/src/components/Initializers/Initializers.tsx
index 55c7547d7f..1b2347c1ef 100644
--- a/frontend/src/components/Initializers/Initializers.tsx
+++ b/frontend/src/components/Initializers/Initializers.tsx
@@ -26,6 +26,7 @@ export default function Initializers() {
   const styles = useInitializersStyles()
   const [settings, setSettings] = useState<InitializerSettingsResponse>(EMPTY_SETTINGS)
   const [registeredInitializers, setRegisteredInitializers] = useState<RegisteredInitializer[]>([])
+  const [catalogUnavailable, setCatalogUnavailable] = useState(false)
   const [loading, setLoading] = useState(true)
   const [statusMessage, setStatusMessage] = useState<StatusMessage | null>(null)
   const [refetchCount, setRefetchCount] = useState(0)
@@ -55,7 +56,9 @@ export default function Initializers() {
 
       if (registeredResult.status === 'fulfilled') {
         setRegisteredInitializers(registeredResult.value.items)
+        setCatalogUnavailable(false)
       } else {
+        setCatalogUnavailable(true)
         const catalogError = toApiError(registeredResult.reason).detail
         setStatusMessage((current: StatusMessage | null) =>
           current
@@ -207,10 +210,12 @@ export default function Initializers() {
           <BaselineInitializers
             items={settings.baseline}
             registeredInitializers={registeredInitializers}
+            catalogUnavailable={catalogUnavailable}
           />
           <AdditionalInitializers
             items={settings.additional}
             registeredInitializers={registeredInitializers}
+            catalogUnavailable={catalogUnavailable}
             creating={creating}
             savingInitializerId={savingInitializerId}
             saveErrors={saveErrors}
diff --git a/frontend/src/components/Initializers/initializerLookup.test.ts b/frontend/src/components/Initializers/initializerLookup.test.ts
index cecf5e57bc..a5f44bf5bb 100644
--- a/frontend/src/components/Initializers/initializerLookup.test.ts
+++ b/frontend/src/components/Initializers/initializerLookup.test.ts
@@ -44,4 +44,22 @@ describe('resolveRegisteredInitializer', () => {
     expect(result.initializer_name).toBe('target')
     expect(result.initializer_type).toBe('UnknownInitializer')
   })
+
+  it('returns a "temporarily unavailable" placeholder when the catalog fetch failed', () => {
+    const result = resolveRegisteredInitializer('target', [], true)
+
+    expect(result).toEqual({
+      initializer_name: 'target',
+      initializer_type: 'UnknownInitializer',
+      description: 'Catalog metadata temporarily unavailable.',
+      required_env_vars: [],
+      supported_parameters: [],
+    })
+  })
+
+  it('still matches by name when the catalog is available', () => {
+    const result = resolveRegisteredInitializer('target', registered, false)
+
+    expect(result).toBe(registered[0])
+  })
 })
diff --git a/frontend/src/components/Initializers/initializerLookup.ts b/frontend/src/components/Initializers/initializerLookup.ts
index 73b3d889b1..94d0ff10bd 100644
--- a/frontend/src/components/Initializers/initializerLookup.ts
+++ b/frontend/src/components/Initializers/initializerLookup.ts
@@ -10,12 +10,23 @@ import type { RegisteredInitializer } from '@/types'
 export function resolveRegisteredInitializer(
   initializerName: string,
   registeredInitializers: RegisteredInitializer[],
+  catalogUnavailable?: boolean,
 ): RegisteredInitializer {
   const match = registeredInitializers.find((item) => item.initializer_name === initializerName)
   if (match) {
     return match
   }
 
+  if (catalogUnavailable) {
+    return {
+      initializer_name: initializerName,
+      initializer_type: 'UnknownInitializer',
+      description: 'Catalog metadata temporarily unavailable.',
+      required_env_vars: [],
+      supported_parameters: [],
+    }
+  }
+
   return {
     initializer_name: initializerName,
     initializer_type: 'UnknownInitializer',