Skip to content

Commit c5a3a5b

Browse files
committed
Adding tool default value as string.empty instead of null
1 parent be3077a commit c5a3a5b

3 files changed

Lines changed: 385 additions & 13 deletions

File tree

src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NetworkingWorkloadToolExecutor.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public string CommandLineLinuxClient
4949
{
5050
get
5151
{
52-
return this.Parameters.GetValue<string>(nameof(this.CommandLineLinuxClient));
52+
return this.Parameters.GetValue<string>(nameof(this.CommandLineLinuxClient), string.Empty);
5353
}
5454

5555
set
@@ -65,7 +65,7 @@ public string CommandLineLinuxServer
6565
{
6666
get
6767
{
68-
return this.Parameters.GetValue<string>(nameof(this.CommandLineLinuxServer));
68+
return this.Parameters.GetValue<string>(nameof(this.CommandLineLinuxServer), string.Empty);
6969
}
7070

7171
set
@@ -81,7 +81,7 @@ public string CommandLineWindowsClient
8181
{
8282
get
8383
{
84-
return this.Parameters.GetValue<string>(nameof(this.CommandLineWindowsClient));
84+
return this.Parameters.GetValue<string>(nameof(this.CommandLineWindowsClient), string.Empty);
8585
}
8686

8787
set
@@ -97,7 +97,7 @@ public string CommandLineWindowsServer
9797
{
9898
get
9999
{
100-
return this.Parameters.GetValue<string>(nameof(this.CommandLineWindowsServer));
100+
return this.Parameters.GetValue<string>(nameof(this.CommandLineWindowsServer), string.Empty);
101101
}
102102

103103
set

src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/SockPerf/SockPerfExecutor.cs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -131,15 +131,6 @@ public double ConfidenceLevel
131131
/// </summary>
132132
protected IAsyncPolicy ProcessStartRetryPolicy { get; set; }
133133

134-
/// <summary>
135-
/// Produces powershell script parameters using the workload parameters provided.
136-
/// </summary>
137-
/// <returns>Powershell script parameters as a string.</returns>
138-
protected override string GetCommandLineArguments()
139-
{
140-
return string.Empty;
141-
}
142-
143134
/// <summary>
144135
/// Initializes the environment and dependencies for running the tool.
145136
/// </summary>

0 commit comments

Comments
 (0)