Skip to content

Commit f7406c3

Browse files
authored
Add --show-tcp-retrans flag to NTttcp client command line for Linux scenarios. Feedback from Azure Core networking team. (#678)
1 parent 1196746 commit f7406c3

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.0.10
1+
3.0.11

src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpExecutor.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ private string GetWindowsSpecificCommandLine()
460460
private string GetLinuxSpecificCommandLine()
461461
{
462462
string serverIPAddress = this.GetLayoutClientInstances(ClientRole.Server).First().IPAddress;
463-
return $"{(this.IsInClientRole ? "-s" : "-r")} " +
463+
string commandLine = $"{(this.IsInClientRole ? "-s" : "-r")} " +
464464
$"-V " +
465465
$"-m {this.ThreadCount},*,{serverIPAddress} " +
466466
$"-W {NTttcpExecutor.DefaultWarmupTime.TotalSeconds} " +
@@ -476,6 +476,13 @@ private string GetLinuxSpecificCommandLine()
476476
$"{((this.IsInClientRole && this.ConnectionsPerThread != null) ? $"-l {this.ConnectionsPerThread}" : string.Empty)} " +
477477
$"{(this.NoSyncEnabled == true ? "-N" : string.Empty)} " +
478478
$"{((this.DevInterruptsDifferentiator != null) ? $"--show-dev-interrupts {this.DevInterruptsDifferentiator}" : string.Empty)}".Trim();
479+
480+
if (this.IsInClientRole && this.Protocol.ToLowerInvariant() == "tcp")
481+
{
482+
commandLine += " --show-tcp-retrans";
483+
}
484+
485+
return commandLine.Trim();
479486
}
480487
}
481488
}

0 commit comments

Comments
 (0)