From 625fbe8634b9bc9354ed78b85c709866fe887c8a Mon Sep 17 00:00:00 2001 From: fei <204683769+feiiiiii5@users.noreply.github.com> Date: Tue, 29 Sep 2026 15:26:33 +0800 Subject: [PATCH] docs: correct three README errors found by following them The root quickstart reads FOUNDRY_MODEL_DEPLOYMENT_NAME, which is a variable in our dotnet integration workflow but not one FoundryChatClient reads -- it uses FOUNDRY_MODEL, as python/README.md already says. Uncommenting the line as written raises "Model is required". 01-get-started marks FOUNDRY_MODEL "optional, defaults to gpt-4o". It has no default; the constructor raises when it is unset, which test_foundry_chat_client.py pins. Only the comment is wrong. 01-get-started also refers to a Sample 08 that does not exist here. The hosting samples moved to the durable-extension repo, which the same file already links. --- README.md | 2 +- python/samples/01-get-started/README.md | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index dd6565de539..ede113551eb 100644 --- a/README.md +++ b/README.md @@ -128,7 +128,7 @@ async def main(): client=FoundryChatClient( credential=AzureCliCredential(), # project_endpoint=os.environ["FOUNDRY_PROJECT_ENDPOINT"], - # model=os.environ["FOUNDRY_MODEL_DEPLOYMENT_NAME"], + # model=os.environ["FOUNDRY_MODEL"], ), name="HaikuAgent", instructions="You are an upbeat assistant that writes beautifully.", diff --git a/python/samples/01-get-started/README.md b/python/samples/01-get-started/README.md index 68a290a37ac..74aad7cccaa 100644 --- a/python/samples/01-get-started/README.md +++ b/python/samples/01-get-started/README.md @@ -9,13 +9,11 @@ concepts of **Agent Framework** one step at a time. pip install agent-framework-foundry ``` -Sample 08 additionally requires `agent-framework-azurefunctions --pre`. - Set the required environment variables: ```bash export FOUNDRY_PROJECT_ENDPOINT="https://your-project-endpoint" -export FOUNDRY_MODEL="gpt-4o" # optional, defaults to gpt-4o +export FOUNDRY_MODEL="gpt-4o" ``` ## Samples