Skip to content

Commit 9d1072d

Browse files
author
damccorm
authored
Found issue when no proxy wasn't set and set up tests better (#242)
* Fixed a couple issues * Cleaning up, added wrong file last time
1 parent 4c33c63 commit 9d1072d

3 files changed

Lines changed: 15 additions & 0 deletions

File tree

api/WebApi.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -339,6 +339,9 @@ export class WebApi {
339339
* @param url: the server url
340340
*/
341341
public isNoProxyHost = function(_url: string) {
342+
if (!process.env.no_proxy) {
343+
return false;
344+
}
342345
const noProxyDomains = (process.env.no_proxy || '')
343346
.split(',')
344347
.map(v => v.toLowerCase());

make.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ target.build = function() {
4040

4141

4242
target.units = function() {
43+
target.build();
44+
4345
pushd('test');
4446
run('npm install ../_build');
4547
popd();

test/units/tsconfig.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"compilerOptions": {
3+
"target": "ES6",
4+
"module": "commonjs",
5+
"moduleResolution": "node"
6+
},
7+
"files": [
8+
"tests.ts"
9+
]
10+
}

0 commit comments

Comments
 (0)