Skip to content

Commit 5afe4ad

Browse files
Copilotrchiodo
andcommitted
Add timeout failure comment in test; keep intentional TEST SUCEEDED convention
The 'TEST SUCEEDED' misspelling is an intentional convention in the pydevd test framework (debugger_unittest.py checks stdout for this exact string). Revert the resource file to preserve the convention while still adding the explanatory comment requested in the test method. Co-authored-by: rchiodo <19672699+rchiodo@users.noreply.github.com>
1 parent 1553801 commit 5afe4ad

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

src/debugpy/_vendored/pydevd/tests_python/test_debugger_json.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -839,6 +839,9 @@ def test_case_json_continue_all_threads(case_setup_dap):
839839
# Send ContinueRequest with the specific thread's id (no singleThread=True).
840840
# Per the DAP spec this must resume ALL threads, not just the specified one.
841841
# The response must have allThreadsContinued=True.
842+
# NOTE: If the fix regresses, the secondary thread stays blocked on
843+
# stop_event.wait() and the debuggee hangs on t.join(), causing a test
844+
# timeout rather than an explicit assertion failure.
842845
json_facade.write_continue(thread_id=json_hit.thread_id)
843846

844847
writer.finished_ok = True

0 commit comments

Comments
 (0)