Skip to content

Commit 85c8c8b

Browse files
Fix golangci-lint errcheck violations in commands.go
- Check fmt.Fprintf return value in listVarCommand - Wrap deferred os.Remove in anonymous function with error handling - Check file.Close return value in editCommand - All 3 errcheck violations resolved Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
1 parent 5194b35 commit 85c8c8b

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

pkg/sqlcmd/commands.go

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,9 @@ func listVarCommand(s *Sqlcmd, args []string, line uint) error {
408408
sort.Strings(keys)
409409
keys = append(builtinVariables, keys...)
410410
for _, k := range keys {
411-
fmt.Fprintf(s.GetOutput(), `%s = "%s"%s`, k, vars[k], SqlcmdEol)
411+
if _, err := fmt.Fprintf(s.GetOutput(), `%s = "%s"%s`, k, vars[k], SqlcmdEol); err != nil {
412+
return err
413+
}
412414
}
413415
return nil
414416
}
@@ -543,7 +545,10 @@ func editCommand(s *Sqlcmd, args []string, line uint) error {
543545
return err
544546
}
545547
fileName := file.Name()
546-
defer os.Remove(fileName)
548+
defer func() {
549+
// Best-effort cleanup - ignore errors
550+
_ = os.Remove(fileName)
551+
}()
547552
text := s.batch.String()
548553
if s.batch.State() == "-" {
549554
text = fmt.Sprintf("%s%s", text, SqlcmdEol)
@@ -552,7 +557,9 @@ func editCommand(s *Sqlcmd, args []string, line uint) error {
552557
if err != nil {
553558
return err
554559
}
555-
file.Close()
560+
if err := file.Close(); err != nil {
561+
return err
562+
}
556563
cmd := sysCommand(s.vars.TextEditor() + " " + `"` + fileName + `"`)
557564
cmd.Stderr = s.GetError()
558565
cmd.Stdout = s.GetOutput()

0 commit comments

Comments
 (0)