fix: address Copilot review feedback round 6

Addresses review #3737557661:

1. Password note wording: Fixed misleading claim that password is not
   stored in committed files. Now clarifies it's a dev-only default
   checked into repo for convenience.

2. MSSQL profile name: Updated docs to match devcontainer.json profile
   name 'sqlcmd-container (use SQLCMDPASSWORD env var)'

3. workspaceFolder mismatch: Changed from variable-based path to
   fixed '/workspaces/go-sqlcmd' to match docker-compose.yml mount

4. go.testEnvVars password: Now uses env:SQLCMDPASSWORD instead of
   hardcoded value, so VS Code tests use same password as container

5. ARM64 architecture support: Added architecture detection for
   golangci-lint with separate SHA256 checksums for amd64/arm64

6. Alias management: Now uses ~/.bash_aliases.d/ directory instead
   of overwriting ~/.bash_aliases, preserving user's custom aliases

Author: dlevy-msft-sql

.devcontainer/Dockerfile

@@ -16,13 +16,23 @@ ENV PATH="/opt/mssql-tools18/bin:${PATH}"
 
 # Install golangci-lint for code quality
 # Download pre-built binary with SHA256 checksum verification (supply chain security)
+# Supports both amd64 and arm64 architectures
 ARG GOLANGCI_LINT_VERSION=1.64.8
-ARG GOLANGCI_LINT_SHA256=b6270687afb143d019f387c791cd2a6f1cb383be9b3124d241ca11bd3ce2e54e
-RUN curl -fsSLO "https://github.com/golangci/golangci-lint/releases/download/v${GOLANGCI_LINT_VERSION}/golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64.tar.gz" \
-    && echo "${GOLANGCI_LINT_SHA256}  golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64.tar.gz" | sha256sum -c - \
-    && tar -xzf "golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64.tar.gz" \
-    && mv "golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64/golangci-lint" /usr/local/bin/ \
-    && rm -rf "golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64" "golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64.tar.gz" \
+ARG GOLANGCI_LINT_SHA256_AMD64=b6270687afb143d019f387c791cd2a6f1cb383be9b3124d241ca11bd3ce2e54e
+ARG GOLANGCI_LINT_SHA256_ARM64=a6ab58ebcb1c48572622146cdaec2956f56871038a54ed1149f1386e287789a5
+RUN ARCH=$(dpkg --print-architecture) \
+    && if [ "$ARCH" = "amd64" ]; then \
+         CHECKSUM="${GOLANGCI_LINT_SHA256_AMD64}"; \
+       elif [ "$ARCH" = "arm64" ]; then \
+         CHECKSUM="${GOLANGCI_LINT_SHA256_ARM64}"; \
+       else \
+         echo "Unsupported architecture: $ARCH" && exit 1; \
+       fi \
+    && curl -fsSLO "https://github.com/golangci/golangci-lint/releases/download/v${GOLANGCI_LINT_VERSION}/golangci-lint-${GOLANGCI_LINT_VERSION}-linux-${ARCH}.tar.gz" \
+    && echo "${CHECKSUM}  golangci-lint-${GOLANGCI_LINT_VERSION}-linux-${ARCH}.tar.gz" | sha256sum -c - \
+    && tar -xzf "golangci-lint-${GOLANGCI_LINT_VERSION}-linux-${ARCH}.tar.gz" \
+    && mv "golangci-lint-${GOLANGCI_LINT_VERSION}-linux-${ARCH}/golangci-lint" /usr/local/bin/ \
+    && rm -rf "golangci-lint-${GOLANGCI_LINT_VERSION}-linux-${ARCH}" "golangci-lint-${GOLANGCI_LINT_VERSION}-linux-${ARCH}.tar.gz" \
     && golangci-lint --version
 
 # Install additional Go tools (pinned versions for reproducibility)

.devcontainer/README.md

@@ -77,9 +77,9 @@ The SQL Server instance is accessible at:
 - **Password**: Available via `$SQLCMDPASSWORD` environment variable
 - **Database**: `master` (default) or `SqlCmdTest` (created for testing)
 
-> **Note**: The password is set via environment variables and is not stored in any committed files.
-> For the default devcontainer setup, the password is `SqlCmd@2025!`.
-> When using VS Code's MSSQL extension, copy this value from `$SQLCMDPASSWORD` when prompted.
+> **Note**: The SQL Server password for this devcontainer is provided via the `$SQLCMDPASSWORD` environment variable and is a non-production, development-only default.
+> For the default devcontainer setup, the password value (`SqlCmd@2025!`) is checked into this repository for convenience; override it via environment variables or Codespaces/CI secrets for non-local use.
+> When using VS Code's MSSQL extension, copy the value from `$SQLCMDPASSWORD` when prompted.
 
 ### Using the Built-in sqlcmd
 
@@ -109,7 +109,7 @@ sql-legacy -Q "SELECT 1 AS test"
 
 ### VS Code SQL Extension
 
-The MSSQL extension is pre-configured with a connection profile named **"sqlcmd-container"**. Click the SQL Server icon in the Activity Bar to connect.
+The MSSQL extension is pre-configured with a connection profile named **"sqlcmd-container (use SQLCMDPASSWORD env var)"**. Click the SQL Server icon in the Activity Bar to connect.
 
 ### Connecting from Host Machine Tools
 

.devcontainer/devcontainer.json

@@ -2,7 +2,7 @@
     "name": "go-sqlcmd Development",
     "dockerComposeFile": "docker-compose.yml",
     "service": "devcontainer",
-    "workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
+    "workspaceFolder": "/workspaces/go-sqlcmd",
     "shutdownAction": "stopCompose",
 
     // Configure tool-specific properties
@@ -26,7 +26,7 @@
                 "go.testEnvVars": {
                     "SQLCMDSERVER": "localhost",
                     "SQLCMDUSER": "sa",
-                    "SQLCMDPASSWORD": "SqlCmd@2025!",
+                    "SQLCMDPASSWORD": "${env:SQLCMDPASSWORD}",
                     "SQLCMDDATABASE": "master"
                 },
                 "mssql.connections": [

.devcontainer/post-create.sh

@@ -63,9 +63,10 @@ if [ -f ".devcontainer/mssql/setup.sql" ]; then
     fi
 fi
 
-# Create useful aliases in a dedicated file (safe and idempotent)
+# Create useful aliases in a dedicated directory (safe and idempotent)
 echo "🔧 Setting up helpful aliases..."
-cat > ~/.bash_aliases << 'EOF'
+mkdir -p ~/.bash_aliases.d
+cat > ~/.bash_aliases.d/go-sqlcmd << 'EOF'
 # go-sqlcmd development aliases
 alias gtest='go test ./...'
 alias gtest-short='go test -short ./...'
@@ -90,11 +91,23 @@ alias test-db='~/bin/sqlcmd -S localhost -U sa -P "$SQLCMDPASSWORD" -C -Q "SELEC
 alias rebuild='go build -o ~/bin/sqlcmd ./cmd/modern && echo "Rebuilt sqlcmd"'
 EOF
 
-# Ensure .bash_aliases is sourced from .bashrc
-if ! grep -q 'source ~/.bash_aliases' ~/.bashrc 2>/dev/null; then
-    echo '' >> ~/.bashrc
-    echo '# Source aliases file' >> ~/.bashrc
-    echo 'if [ -f ~/.bash_aliases ]; then source ~/.bash_aliases; fi' >> ~/.bashrc
+# Ensure aliases are sourced from .bashrc
+if ! grep -q 'go-sqlcmd aliases' ~/.bashrc 2>/dev/null; then
+    {
+        echo ''
+        echo '# go-sqlcmd aliases'
+        echo 'if [ -f ~/.bash_aliases ]; then'
+        echo '    # Source traditional aliases file if present'
+        echo '    . ~/.bash_aliases'
+        echo 'fi'
+        echo ''
+        echo 'if [ -d ~/.bash_aliases.d ]; then'
+        echo '    # Source all alias snippets from ~/.bash_aliases.d'
+        echo '    for f in ~/.bash_aliases.d/*; do'
+        echo '        [ -r "$f" ] && . "$f"'
+        echo '    done'
+        echo 'fi'
+    } >> ~/.bashrc
 fi
 
 echo ""