fix: apply lessons learned from go-mssqldb PR #317

Dockerfile:
- Fix image tag format: 1.24-bookworm (not 1-1.24-bookworm)

docker-compose.yml:
- Add both SA_PASSWORD and MSSQL_SA_PASSWORD for CI compatibility
  (different SQL Server images use different env vars)

post-create.sh:
- Add dynamic workspace detection with robust fallback
- Handles different clone names (go-sqlcmd, fork names, etc.)

setup.sql:
- Add TRY/CATCH error handling for contained database operations
- Prevents script failure on unsupported SQL Server configurations

.dockerignore:
- Add .devcontainer/ to reduce build context size

Reference: microsoft/go-mssqldb#317

Author: dlevy-msft-sql

.devcontainer/Dockerfile

@@ -1,5 +1,5 @@
 # go-sqlcmd Development Container
-FROM mcr.microsoft.com/devcontainers/go:1-1.24-bookworm
+FROM mcr.microsoft.com/devcontainers/go:1.24-bookworm
 
 # Install additional OS packages
 RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \

.devcontainer/docker-compose.yml

@@ -20,6 +20,7 @@ services:
     restart: unless-stopped
     environment:
       ACCEPT_EULA: "Y"
+      SA_PASSWORD: "SqlCmd@2025!"
       MSSQL_SA_PASSWORD: "SqlCmd@2025!"
       MSSQL_PID: "Developer"
     volumes:

.devcontainer/mssql/setup.sql

@@ -13,12 +13,23 @@ END
 GO
 
 -- Enable contained database authentication for testing
-EXEC sp_configure 'contained database authentication', 1;
-RECONFIGURE;
+-- Use TRY/CATCH in case this fails on certain SQL Server configurations
+BEGIN TRY
+    EXEC sp_configure 'contained database authentication', 1;
+    RECONFIGURE;
+END TRY
+BEGIN CATCH
+    PRINT 'Note: Could not enable contained database authentication (may already be enabled or not supported)';
+END CATCH;
 GO
 
 -- Make SqlCmdTest a contained database for testing
-ALTER DATABASE SqlCmdTest SET CONTAINMENT = PARTIAL;
+BEGIN TRY
+    ALTER DATABASE SqlCmdTest SET CONTAINMENT = PARTIAL;
+END TRY
+BEGIN CATCH
+    PRINT 'Note: Could not set database containment (may not be supported)';
+END CATCH;
 GO
 
 USE SqlCmdTest;

.devcontainer/post-create.sh

@@ -3,6 +3,23 @@ set -e
 
 echo "=== go-sqlcmd Development Container Setup ==="
 
+# Dynamic workspace detection with fallback
+if [ -n "${WORKSPACE_FOLDER}" ] && [ -d "${WORKSPACE_FOLDER}" ]; then
+    cd "${WORKSPACE_FOLDER}"
+elif [ -d "/workspaces/go-sqlcmd" ]; then
+    cd /workspaces/go-sqlcmd
+else
+    # Find workspace by looking for go.mod
+    workspace_go_mod="$(find /workspaces -maxdepth 2 -name 'go.mod' -type f -print -quit 2>/dev/null)"
+    if [ -n "$workspace_go_mod" ]; then
+        cd "$(dirname "$workspace_go_mod")"
+    else
+        echo "Error: Could not determine workspace directory" >&2
+        exit 1
+    fi
+fi
+echo "📁 Working in: $(pwd)"
+
 # Download Go dependencies
 echo "📦 Downloading Go dependencies..."
 go mod download

.dockerignore

@@ -60,6 +60,9 @@ CHANGELOG*
 .pipelines/
 appveyor.yml
 
+# Dev container configuration (not needed in image build)
+.devcontainer/
+
 # Test output and temporary files
 *.log
 *.tmp