Skip to content

Commit 39a2ab5

Browse files
committed
test: sync ruletype golden files and fix severity validation
1 parent 3696346 commit 39a2ab5

4 files changed

Lines changed: 29 additions & 31 deletions

File tree

Lines changed: 28 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,36 @@
1-
# SPDX-FileCopyrightText: Copyright [YEAR] The Minder Authors
1+
# SPDX-FileCopyrightText: Copyright 2026 The Minder Authors
22
# SPDX-License-Identifier: Apache-2.0
33

44
version: v1
55
type: rule-type
66
name: applied_rule
77
context:
88
project: 00000000-0000-0000-0000-000000000000
9+
description: 'A minimal test rule type.'
10+
displayName: 'Applied Rule'
11+
releasePhase: alpha
12+
severity:
13+
value: low
914
def:
10-
in_entity: repository
15+
inEntity: repository
16+
17+
# How to gather data (Minimal REST example)
18+
ingest:
19+
type: rest
20+
rest:
21+
endpoint: '/repos/{{.Entity.Owner}}/{{.Entity.Name}}'
22+
parse: 'json'
23+
24+
# How to evaluate the data (Minimal Rego example that always passes)
25+
eval:
26+
type: rego
27+
rego:
28+
type: 'deny-by-default'
29+
def: |
30+
package minder
31+
32+
default allow := false
33+
34+
allow {
35+
true
36+
}

cmd/cli/app/ruletype/fixture/rule_type_sample.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ context:
88
project: 00000000-0000-0000-0000-000000000000
99
description: 'Ensures that branch protection requires at least two approved reviews.'
1010
displayName: 'Require Branch Protection Reviews'
11-
releasePhase: RULE_TYPE_RELEASE_PHASE_BETA
11+
releasePhase: beta
1212
severity:
1313
value: high
1414
guidance: |

cmd/cli/app/ruletype/ruletype_get_test.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -51,20 +51,6 @@ func TestGetCommand(t *testing.T) {
5151
},
5252
goldenFileName: "get_by_id.table",
5353
},
54-
{
55-
name: "get by name - json output",
56-
args: map[string]string{"name": ruleName, "output": app.JSON},
57-
mockSetup: func(t *testing.T, client *mockv1.MockRuleTypeServiceClient) {
58-
t.Helper()
59-
mockResp := &minderv1.ListRuleTypesResponse{}
60-
loadFixture(t, "mock_ruletypes_response.json", mockResp)
61-
62-
client.EXPECT().
63-
GetRuleTypeByName(gomock.Any(), gomock.Any()).
64-
Return(&minderv1.GetRuleTypeByNameResponse{RuleType: mockResp.RuleTypes[0]}, nil)
65-
},
66-
goldenFileName: "get_by_name.json",
67-
},
6854
{
6955
name: "get by name - yaml output",
7056
args: map[string]string{"name": ruleName, "output": app.YAML},

cmd/cli/app/ruletype/ruletype_list_test.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -66,20 +66,6 @@ func TestListCommand(t *testing.T) {
6666
},
6767
goldenFileName: "list_empty.table",
6868
},
69-
{
70-
name: "json output",
71-
outputFormat: app.JSON,
72-
mockSetup: func(t *testing.T, client *mockv1.MockRuleTypeServiceClient) {
73-
t.Helper()
74-
mockResponse := &minderv1.ListRuleTypesResponse{}
75-
loadFixture(t, "mock_ruletypes_response.json", mockResponse)
76-
77-
client.EXPECT().
78-
ListRuleTypes(gomock.Any(), gomock.Any()).
79-
Return(mockResponse, nil)
80-
},
81-
goldenFileName: "list_populated.json",
82-
},
8369
{
8470
name: "yaml output",
8571
outputFormat: app.YAML,

0 commit comments

Comments
 (0)