fix: Don't resolve attribute values to attribute with same name

Issue-367: #367

Author: pawamoy

src/_griffe/models.py

@@ -2075,9 +2075,22 @@ def resolve(self, name: str) -> str:
         Returns:
             The resolved name.
         """
-        # We're in an `__init__` method and name is a parameter name.
-        if self.parent and self.name == "__init__" and name in self.parameters:
-            return f"{self.parent.path}({name})"
+        # We're in an `__init__` method...
+        if self.parent and self.name == "__init__":
+            # ...and name is a parameter name: resolve to the parameter.
+            if name in self.parameters:
+                return f"{self.parent.path}({name})"
+
+            # Kind of a special case: we avoid resolving to instance-attributes from a function scope.
+            # See issue https://github.com/mkdocstrings/griffe/issues/367.
+            resolved = super().resolve(name)
+            try:
+                obj = self.modules_collection.get_member(resolved)
+            except KeyError:
+                return resolved
+            if obj.is_attribute and "instance-attribute" in obj.labels:
+                raise NameResolutionError(name)
+            return resolved
         return super().resolve(name)
 
     def as_dict(self, **kwargs: Any) -> dict[str, Any]:

tests/test_models.py

@@ -526,3 +526,16 @@ def test_delete_parameters() -> None:
     del parameters[0]
     assert "x" not in parameters
     assert len(parameters) == 0
+
+
+def test_not_resolving_attribute_value_to_itself() -> None:
+    """Attribute values with same name don't resolve to themselves."""
+    with temporary_visited_module(
+        """
+        class A:
+            def __init__(self):
+                x = "something"
+                self.x = x
+        """,
+    ) as module:
+        assert module["A.x"].value.canonical_path == "x"  # Not `module.A.x`.