Skip to content

Commit eea0af1

Browse files
committed
chore: Update comment
1 parent 0279998 commit eea0af1

1 file changed

Lines changed: 1 addition & 12 deletions

File tree

src/_griffe/loader.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -189,18 +189,7 @@ def _post_load(self, module: Module, obj_path: str) -> Object | Alias:
189189
# Pre-emptively expand exports (`__all__` values),
190190
# as well as wildcard imports (without ever loading additional packages).
191191
# This is a best-effort to return the most correct API data
192-
# before firing the `on_package_loaded` event,
193-
# because extensions registering hooks for this event
194-
# might trigger computation of inherited members,
195-
# which are cached, and could be cached too early
196-
# (aliases to base class still being unresolvable,
197-
# preventing to fetch some inherited members).
198-
#
199-
# Another solution to this "too-early-computation-of-inherited-members"
200-
# issue would be to stop caching resolved bases and inherited members,
201-
# but we would have to measure the performance impact of this change,
202-
# as each use of `obj["name"]` would compute resolved bases, MRO
203-
# and inherited members again.
192+
# before firing the `on_package_loaded` event.
204193
#
205194
# Packages that wildcard imports from external, non-loaded packages
206195
# will still have incomplete data, requiring subsequent calls to

0 commit comments

Comments
 (0)