Skip to content

Commit fdeb16f

Browse files
committed
refactor: Privatize/remove objects
1 parent 6cafb5a commit fdeb16f

7 files changed

Lines changed: 9 additions & 17 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,8 +343,8 @@ for the initial code allowing to compare two Griffe trees.
343343
- All parameters of the [`load_git`][griffe.git.load_git] function, except `module`, are now keyword-only.
344344
- Parameter `try_relative_path` of the [`load_git`][griffe.git.load_git] function was removed.
345345
- Parameter `commit` was renamed `ref` in the [`load_git`][griffe.git.load_git] function.
346-
- Parameter `commit` was renamed `ref` in the [`tmp_worktree`][griffe.git.tmp_worktree] helper, which will probably become private later.
347-
- Parameters `ref` and `repo` switched positions in the [`tmp_worktree`][griffe.git.tmp_worktree] helper.
346+
- Parameter `commit` was renamed `ref` in the `tmp_worktree` helper, which will probably become private later.
347+
- Parameters `ref` and `repo` switched positions in the `tmp_worktree` helper.
348348
- All parameters of the [`resolve_aliases`][griffe.loader.GriffeLoader.resolve_aliases] method are now keyword-only.
349349
- Parameters `only_exported` and `only_known_modules` of the [`resolve_module_aliases`][griffe.loader.GriffeLoader.resolve_module_aliases]
350350
method were removed. This method is most probably not used by anyone, and will probably be made private in the future.

src/griffe/docstrings/markdown.py

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/griffe/extensions/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
InspectorExtension,
88
VisitorExtension,
99
When,
10-
load_extension,
1110
load_extensions,
1211
)
1312

@@ -16,7 +15,6 @@
1615
"Extensions",
1716
"ExtensionType",
1817
"InspectorExtension",
19-
"load_extension",
2018
"load_extensions",
2119
"VisitorExtension",
2220
"When",

src/griffe/extensions/base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ def _load_extension_path(path: str) -> ModuleType:
402402
return module
403403

404404

405-
def load_extension(
405+
def _load_extension(
406406
extension: str | dict[str, Any] | ExtensionType | type[ExtensionType],
407407
) -> ExtensionType | list[ExtensionType]:
408408
"""Load a configured extension.
@@ -500,7 +500,7 @@ def load_extensions(exts: Sequence[str | dict[str, Any] | ExtensionType | type[E
500500
"""
501501
extensions = Extensions()
502502
for extension in exts:
503-
ext = load_extension(extension)
503+
ext = _load_extension(extension)
504504
if isinstance(ext, list):
505505
extensions.add(*ext)
506506
else:

src/griffe/extensions/hybrid.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
from griffe.agents.nodes import ObjectNode
99
from griffe.exceptions import ExtensionError
10-
from griffe.extensions.base import InspectorExtension, VisitorExtension, When, load_extension
10+
from griffe.extensions.base import InspectorExtension, VisitorExtension, When, _load_extension
1111
from griffe.importer import dynamic_import
1212
from griffe.logger import get_logger
1313

@@ -36,7 +36,7 @@ class HybridExtension(VisitorExtension):
3636

3737
def __init__(
3838
self,
39-
extensions: Sequence[str | dict[str, Any] | InspectorExtension | type[Extension]],
39+
extensions: Sequence[str | dict[str, Any] | InspectorExtension | type[InspectorExtension]],
4040
object_paths: Sequence[str | Pattern] | None = None,
4141
) -> None:
4242
"""Initialize the extension.
@@ -49,7 +49,7 @@ def __init__(
4949
Raises:
5050
ExtensionError: When the passed extension is not an inspector extension.
5151
"""
52-
self._extensions: list[InspectorExtension] = [load_extension(ext) for ext in extensions] # type: ignore[misc]
52+
self._extensions: list[InspectorExtension] = [_load_extension(ext) for ext in extensions] # type: ignore[misc]
5353
for extension in self._extensions:
5454
if not isinstance(extension, InspectorExtension):
5555
raise ExtensionError(

src/griffe/finder.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,6 @@
2525
_editable_editables_patterns = [re.compile(pat) for pat in (r"^__editables_\w+\.py$", "^_editable_impl_\\w+\\.py$")]
2626
_editable_setuptools_patterns = [re.compile(pat) for pat in ("^__editable__\\w+\\.py$",)]
2727
_editable_scikit_build_core_patterns = [re.compile(pat) for pat in (r"^_\w+_editable.py$",)]
28-
_editable_patterns = (
29-
*_editable_editables_patterns,
30-
*_editable_setuptools_patterns,
31-
*_editable_scikit_build_core_patterns,
32-
)
3328

3429

3530
def _match_pattern(string: str, patterns: Sequence[Pattern]) -> bool:

src/griffe/git.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def _get_repo_root(path: str | Path) -> str:
7777

7878

7979
@contextmanager
80-
def tmp_worktree(repo: str | Path = ".", ref: str = "HEAD") -> Iterator[Path]:
80+
def _tmp_worktree(repo: str | Path = ".", ref: str = "HEAD") -> Iterator[Path]:
8181
"""Context manager that checks out the given reference in the given repository to a temporary worktree.
8282
8383
Parameters:
@@ -149,7 +149,7 @@ def load_git(
149149
Returns:
150150
A loaded module.
151151
"""
152-
with tmp_worktree(repo, ref) as worktree:
152+
with _tmp_worktree(repo, ref) as worktree:
153153
search_paths = [worktree / path for path in search_paths or ["."]]
154154
if isinstance(module, Path):
155155
module = worktree / module

0 commit comments

Comments
 (0)