Skip to content

Commit 52d7e76

Browse files
committed
Merge pull request #738 from aboch/bb
Fix bug in bridge driver
2 parents 5978c27 + fd3d1cc commit 52d7e76

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

drivers/bridge/bridge.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,9 @@ func (d *driver) DeleteNetwork(nid string) error {
738738

739739
// We only delete the bridge when it's not the default bridge. This is keep the backward compatible behavior.
740740
if !config.DefaultBridge {
741-
err = netlink.LinkDel(n.bridge.Link)
741+
if err := netlink.LinkDel(n.bridge.Link); err != nil {
742+
logrus.Warnf("Failed to remove bridge interface %s on network %s delete: %v", config.BridgeName, nid, err)
743+
}
742744
}
743745

744746
return d.storeDelete(config)
@@ -1037,9 +1039,8 @@ func (d *driver) DeleteEndpoint(nid, eid string) error {
10371039
// Remove port mappings. Do not stop endpoint delete on unmap failure
10381040
n.releasePorts(ep)
10391041

1040-
// Try removal of link. Discard error: link pair might have
1041-
// already been deleted by sandbox delete. Make sure defer
1042-
// does not see this error either.
1042+
// Try removal of link. Discard error: it is a best effort.
1043+
// Also make sure defer does not see this error either.
10431044
if link, err := netlink.LinkByName(ep.srcName); err == nil {
10441045
netlink.LinkDel(link)
10451046
}

0 commit comments

Comments
 (0)