Skip to content

Commit f20612e

Browse files
committed
Merge pull request #994 from sanimej/fixes
If anonymous container has alias names use it for DNS PTR record
2 parents 94f79d8 + 632d449 commit f20612e

1 file changed

Lines changed: 13 additions & 2 deletions

File tree

network.go

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -851,14 +851,25 @@ func (n *network) updateSvcRecord(ep *endpoint, localEps []*endpoint, isAdd bool
851851
if iface := ep.Iface(); iface.Address() != nil {
852852
myAliases := ep.MyAliases()
853853
if isAdd {
854-
if !ep.isAnonymous() {
854+
// If anonymous endpoint has an alias use the first alias
855+
// for ip->name mapping. Not having the reverse mapping
856+
// breaks some apps
857+
if ep.isAnonymous() {
858+
if len(myAliases) > 0 {
859+
n.addSvcRecords(myAliases[0], iface.Address().IP, true)
860+
}
861+
} else {
855862
n.addSvcRecords(epName, iface.Address().IP, true)
856863
}
857864
for _, alias := range myAliases {
858865
n.addSvcRecords(alias, iface.Address().IP, false)
859866
}
860867
} else {
861-
if !ep.isAnonymous() {
868+
if ep.isAnonymous() {
869+
if len(myAliases) > 0 {
870+
n.deleteSvcRecords(myAliases[0], iface.Address().IP, true)
871+
}
872+
} else {
862873
n.deleteSvcRecords(epName, iface.Address().IP, true)
863874
}
864875
for _, alias := range myAliases {

0 commit comments

Comments
 (0)