Fix veth leak in overlay driver

aboch · aboch · commit fbf67cbafd7c · 2016-03-07T15:17:22.000-08:00
- Because of the lazy logic in Leave(), the overlay
  veth end is not moved from the sandbox to the host
  network namspace until the last endpoint leaves.
  We cannot rely on this logic to clear the veth pairs,
  because on last endpoint leave we have no reference to
  the other N-1 veth names.

- The fix is to delete the container veth end on endpoint delete.
  This anyways deletes both veth ends, regardless they are in different
  namespaces.

Signed-off-by: Alessandro Boch &lt;aboch@docker.com&gt;
diff --git a/drivers/overlay/joinleave.go b/drivers/overlay/joinleave.go
@@ -54,7 +54,7 @@ func (d *driver) Join(nid, eid string, sboxKey string, jinfo driverapi.JoinInfo,
 		return err
 	}
 
-	ep.ifName = overlayIfName
+	ep.ifName = containerIfName
 
 	// Set the container interface and its peer MTU to 1450 to allow
 	// for 50 bytes vxlan encap (inner eth header(14) + outer IP(20) +

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ func (d *driver) Join(nid, eid string, sboxKey string, jinfo driverapi.JoinInfo,`
`54`	`54`	`return err`
`55`	`55`	`}`
`56`	`56`
`57`		`- ep.ifName = overlayIfName`
	`57`	`+ ep.ifName = containerIfName`
`58`	`58`
`59`	`59`	`// Set the container interface and its peer MTU to 1450 to allow`
`60`	`60`	`// for 50 bytes vxlan encap (inner eth header(14) + outer IP(20) +`