Skip to content

Commit 5461e1a

Browse files
committed
Run the intake gate scenarios as a CI step rather than a pre-commit hook
A pre-commit hook would make node a requirement for anyone running pre-commit --all-files locally, which CONTRIBUTING.md asks Python contributors to do. No-Verification-Needed: CI wiring only Signed-off-by: Max Isbey <224885523+maxisbey@users.noreply.github.com>
1 parent f79219c commit 5461e1a

3 files changed

Lines changed: 4 additions & 7 deletions

File tree

.github/scripts/pr_intake_gate.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// node --test .github/scripts/pr_intake_gate.test.js
66
//
77
// No dependencies; the GitHub client is a small fake defined at the bottom.
8-
// pre-commit runs this whenever the gate script or this file changes.
8+
// CI runs it in the checks job (.github/workflows/shared.yml).
99
'use strict';
1010

1111
const test = require('node:test');

.github/workflows/shared.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@ jobs:
4141
with:
4242
extra_args: --all-files --verbose
4343

44+
- name: PR intake gate scenarios
45+
run: node --test .github/scripts/pr_intake_gate.test.js
46+
4447
- name: Surface types match vendored schema
4548
run: |
4649
uv sync --group codegen --frozen

.pre-commit-config.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@ repos:
4848
language: system
4949
types: [python]
5050
pass_filenames: false
51-
- id: pr-intake-gate
52-
name: PR intake gate scenarios
53-
entry: node --test .github/scripts/pr_intake_gate.test.js
54-
language: system
55-
files: ^\.github/scripts/pr_intake_gate
56-
pass_filenames: false
5751
- id: uv-lock-check
5852
name: Check uv.lock is up to date
5953
entry: uv lock --check

0 commit comments

Comments
 (0)