Intake gate: isolate per-PR failures on assignment; key assignment runs per assignee

Also reword the refused-reopen advice for PRs that passed via a maintainer override, and drop an unused test fixture.

No-Verification-Needed: workflow script, its tests, and config only
Signed-off-by: Max Isbey <224885523+maxisbey@users.noreply.github.com>

Author: maxisbey

.github/scripts/pr_intake_gate.js

@@ -38,7 +38,17 @@ module.exports = async function run({ github, context, core }) {
     });
     const prs = closed.filter((i) => i.pull_request && closingRefs(i.body).includes(issueNumber));
     console.log(`#${issueNumber} assigned to ${assignee}: ${prs.length} gate-closed PR(s) reference it`);
-    for (const pr of prs) await evaluate(pr.number, 'assigned', context.payload.sender?.login, issueNumber);
+    // Evaluate each independently so one transient failure doesn't strand
+    // the rest (this event won't fire again for the same assignment).
+    const failures = [];
+    for (const pr of prs) {
+      try {
+        await evaluate(pr.number, 'assigned', context.payload.sender?.login, issueNumber);
+      } catch (e) {
+        failures.push(`#${pr.number}: ${e.message}`);
+      }
+    }
+    if (failures.length) throw new Error(`Could not re-evaluate ${failures.join('; ')}`);
     return;
   }
 
@@ -150,7 +160,7 @@ module.exports = async function run({ github, context, core }) {
       MARKER,
       `This PR now passes the intake check (${reason}), but GitHub won't let it be reopened — usually because the branch was force-pushed or deleted while the PR was closed, or because another open PR uses the same branch.`,
       '',
-      `If you have another open PR from this branch, please continue there. Otherwise, either push the branch back to \`${pr.head.sha.slice(0, 7)}\` and edit this PR's description to retry, or open a new PR with the same \`Fixes #<issue>\` line.`,
+      `If you have another open PR from this branch, please continue there. Otherwise, either push the branch back to \`${pr.head.sha.slice(0, 7)}\` and edit this PR's description to retry, or open a new PR that links the same issue (if a maintainer had waved this one through, mention that so they can do the same there).`,
     ].join('\n');
   }
 

.github/scripts/pr_intake_gate.test.js

@@ -21,7 +21,6 @@ const PEOPLE = {
   maintainer: { type: 'User', perms: { admin: true, maintain: true, push: true, triage: true, pull: true } },
   triager: { type: 'User', perms: { triage: true, pull: true } }, // e.g. a trusted-contributors team
   outsider: { type: 'User', perms: { pull: true } },
-  another: { type: 'User', perms: { pull: true } },
   'dependabot[bot]': { type: 'Bot', perms: {} },
   'somebot[bot]': { type: 'Bot', perms: {} },
 };
@@ -236,6 +235,19 @@ test('kill switch (ENFORCE=false) reaches the same verdicts but writes nothing',
   }
 });
 
+test('on assignment, one PR failing to re-evaluate does not stop the others (run still fails)', async () => {
+  const world = makeWorld({
+    prs: [
+      pr(3300, 'outsider', { state: 'closed', labels: [LABEL], body: 'Fixes #10', gateComment: true }),
+      pr(3301, 'outsider', { state: 'closed', labels: [LABEL], body: 'Fixes #10', gateComment: true }),
+    ],
+    issues: [issue(10, { assignees: ['outsider'] })],
+  });
+  world.failPullsGet = 3300;
+  await assert.rejects(run(world, assigned(10, 'outsider', 'maintainer'), { enforce: true }), /Could not re-evaluate #3300/);
+  assert.equal(world.prs.get(3301).state, 'open');
+});
+
 test('an API error while checking permissions fails the run rather than closing the PR', async () => {
   const world = makeWorld({ prs: [pr(3300, 'outsider')] });
   world.failPermissionLookup = true;
@@ -297,7 +309,7 @@ function observe(world, expect) {
 // ── A tiny in-memory GitHub ────────────────────────────────────────────────
 
 function makeWorld({ prs = [], issues = [] }) {
-  const world = { prs: new Map(), issues: new Map(), writes: [], failPermissionLookup: false, nextCommentId: 100 };
+  const world = { prs: new Map(), issues: new Map(), writes: [], failPermissionLookup: false, failPullsGet: null, nextCommentId: 100 };
   for (const p of prs) {
     const copy = structuredClone(p);
     copy.comments = copy.comments.map((c) => ({ id: world.nextCommentId++, ...c }));
@@ -326,7 +338,7 @@ function makeWorld({ prs = [], issues = [] }) {
       },
     },
     pulls: {
-      get: async ({ pull_number }) => ({ data: apiPr(getPr(pull_number)) }),
+      get: async ({ pull_number }) => { if (world.failPullsGet === pull_number) throw err(502, 'bad gateway'); return { data: apiPr(getPr(pull_number)) }; },
       update: async ({ pull_number, state }) => {
         const p = getPr(pull_number);
         write(`${state === 'open' ? 'reopen' : 'close'} #${pull_number}`);

.github/workflows/require-linked-issue.yml

@@ -61,7 +61,7 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     concurrency:
-      group: require-linked-issue-${{ github.event.pull_request.number || inputs.pr_number || format('issue-{0}', github.event.issue.number) }}
+      group: require-linked-issue-${{ github.event.pull_request.number || inputs.pr_number || format('issue-{0}-{1}', github.event.issue.number, github.event.assignee.login) }}
       cancel-in-progress: false
     permissions:
       contents: read # check out the gate script from the default branch