Skip to content

Commit 8bbbbc7

Browse files
authored
Merge pull request #237 from modelstudioai/fix/ad-hoc-sign
fix(release): pin Bun 1.3.14 for release binaries
2 parents fc08001 + ff52ede commit 8bbbbc7

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎.github/workflows/publish.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ jobs:
8080
# Keep this pin in sync with any local smoke tests of binary-compile.mjs.
8181
- uses: oven-sh/setup-bun@v2
8282
with:
83-
bun-version: "1.2.19"
83+
bun-version: "1.3.14"
8484

8585
- name: publish-stable
8686
env:
@@ -155,7 +155,7 @@ jobs:
155155
# Keep this pin in sync with any local smoke tests of binary-compile.mjs.
156156
- uses: oven-sh/setup-bun@v2
157157
with:
158-
bun-version: "1.2.19"
158+
bun-version: "1.3.14"
159159

160160
- name: publish-channel
161161
env:

‎tools/release/lib/binary-build.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ function compileOne({ bunTarget, os, arch, exe }, version, outdir, entry) {
165165
}
166166
if (result.stdout) process.stdout.write(result.stdout);
167167
if (result.stderr) process.stderr.write(result.stderr);
168-
// Bun 1.2.19 writes windows-x64 .exe with mode 000 on Unix hosts (oven-sh/bun#21308).
168+
// Bun has written windows-x64 .exe as mode 000 on Unix hosts (oven-sh/bun#21308).
169169
chmodSync(innerPath, 0o755);
170170
// Sign after chmod. Bun's linker signature does not match the final Mach-O bytes.
171171
if (os === "darwin") signDarwinAdhoc(innerPath, { log });

‎tools/release/lib/binary-compile.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* bun tools/release/lib/binary-compile.mjs --entry <path> --outfile <path> --target <bun-target>
44
*
55
* Uses `bun build --compile` (CLI). The Bun.build({ compile }) API on ≤1.2.19
6-
* can exit 0 without writing outfile; CI pins 1.2.19 so we stay on the CLI.
6+
* can exit 0 without writing outfile; CI stays on the CLI.
77
*
88
* Called by binary-build.mjs (Node orchestration stays on Node).
99
*/

0 commit comments

Comments
 (0)