improving

Author: muriloalvesdev

src/main/java/br/com/developers/controller/user/UserController.java

@@ -16,6 +16,8 @@
 import br.com.developers.domain.model.User;
 import br.com.developers.login.dto.LoginDTO;
 import br.com.developers.login.dto.RegisterDTO;
+import br.com.developers.login.dto.UserDTO;
+import br.com.developers.login.http.request.AccessToken;
 import br.com.developers.login.service.UserService;
 import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
@@ -26,7 +28,7 @@
 @RequestMapping("api/user")
 public class UserController {
 
-  private UserService userService;
+  private UserService<RegisterDTO, LoginDTO, User, UserDTO, AccessToken> userService;
 
   @PostMapping("/")
   public ResponseEntity<Object> registerUser(@Validated @RequestBody RegisterDTO registerData) {

src/main/java/br/com/developers/controller/user/login/LoginController.java

@@ -7,7 +7,10 @@
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RestController;
+import br.com.developers.domain.model.User;
 import br.com.developers.login.dto.LoginDTO;
+import br.com.developers.login.dto.RegisterDTO;
+import br.com.developers.login.dto.UserDTO;
 import br.com.developers.login.http.request.AccessToken;
 import br.com.developers.login.service.UserService;
 import lombok.AccessLevel;
@@ -19,7 +22,7 @@
 @RequestMapping("api/auth")
 public class LoginController {
 
-  private UserService userService;
+  private UserService<RegisterDTO, LoginDTO, User, UserDTO, AccessToken> userService;
 
   @PostMapping("/")
   public ResponseEntity<AccessToken> authenticateUser(@Validated @RequestBody LoginDTO loginData) {

src/main/java/br/com/developers/login/service/UserService.java

@@ -1,19 +1,13 @@
 package br.com.developers.login.service;
 
-import br.com.developers.domain.model.User;
-import br.com.developers.login.dto.LoginDTO;
-import br.com.developers.login.dto.RegisterDTO;
-import br.com.developers.login.dto.UserDTO;
-import br.com.developers.login.http.request.AccessToken;
+public interface UserService<R, L, U, D, T> {
+  U registerUser(R dto);
 
-public interface UserService {
-  User registerUser(RegisterDTO registerData);
+  T authenticateUser(L dto);
 
-  AccessToken authenticateUser(LoginDTO loginDto);
+  U update(R dto);
 
-  User update(RegisterDTO registerData);
+  void delete(L dto);
 
-  void delete(LoginDTO loginDTO);
-
-  UserDTO find(String id);
+  D find(String id);
 }

src/main/java/br/com/developers/login/service/impl/UserServiceImpl.java

@@ -28,7 +28,7 @@
 
 @Service
 @AllArgsConstructor(access = AccessLevel.PACKAGE)
-class UserServiceImpl implements UserService {
+class UserServiceImpl implements UserService<RegisterDTO, LoginDTO, User, UserDTO, AccessToken> {
 
   private static final String ROLE_NOT_FOUND = "Fail! -> Cause: %s Role not found in database.";
   private static final String USER_NOT_FOUND = "Fail! -> Cause: User not found with %s [%s]";