From 42da5c4844fd44bc8fad118cd74286a9762994d1 Mon Sep 17 00:00:00 2001 From: Sandhya Bhatia Date: Thu, 8 Oct 2026 16:30:35 -0600 Subject: [PATCH 1/2] style: fix spotless groovy formatting in MdxOnDemandMdxListSerializerTest Fixes a pre-existing closing-paren indentation violation flagged by spotlessGroovyCheck on master, unrelated to any recent feature change. --- .../mdx/model/ondemand/MdxOnDemandMdxListSerializerTest.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mdx-models/src/test/groovy/com/mx/path/model/mdx/model/ondemand/MdxOnDemandMdxListSerializerTest.groovy b/mdx-models/src/test/groovy/com/mx/path/model/mdx/model/ondemand/MdxOnDemandMdxListSerializerTest.groovy index f07a4b21..15abfb07 100644 --- a/mdx-models/src/test/groovy/com/mx/path/model/mdx/model/ondemand/MdxOnDemandMdxListSerializerTest.groovy +++ b/mdx-models/src/test/groovy/com/mx/path/model/mdx/model/ondemand/MdxOnDemandMdxListSerializerTest.groovy @@ -136,7 +136,7 @@ class MdxOnDemandMdxListSerializerTest extends MockeryAndSessionRepository { given: subject = new MdxOnDemandMdxListSerializer( new MixinDefinition(Account, AccountXmlMixin) - ) + ) def transactions = new MdxList() transactions.add(new Account().tap { From 83e554b646a5e8c63e7febda54987614abc4662f Mon Sep 17 00:00:00 2001 From: Sandhya Bhatia Date: Fri, 9 Oct 2026 10:39:23 -0600 Subject: [PATCH 2/2] style: fix remaining spotless groovy formatting across mdx-web and realtime Earlier commit only fixed mdx-models; a stale cached coppuccino plugin resolution (version 8.+) locally masked additional violations that CI's resolved plugin version caught in mdx-web and realtime test sources. Running with --refresh-dependencies reproduced CI's formatter output and surfaced/fixed all remaining violations: - ProductControllerTest.groovy - ProfilesControllerTest.groovy - RecurringTransfersControllerTest.groovy - MdxRealtimeMembersConnectionTest.groovy - MdxRealtimeUsersConnectionTest.groovy ./gradlew spotlessCheck now passes clean across all modules. --- .../controller/ProductControllerTest.groovy | 10 +++--- .../controller/ProfilesControllerTest.groovy | 4 +-- .../RecurringTransfersControllerTest.groovy | 4 +-- .../MdxRealtimeMembersConnectionTest.groovy | 32 +++++++++---------- .../MdxRealtimeUsersConnectionTest.groovy | 16 +++++----- 5 files changed, 33 insertions(+), 33 deletions(-) diff --git a/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/ProductControllerTest.groovy b/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/ProductControllerTest.groovy index e6a91ca2..55a8632e 100644 --- a/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/ProductControllerTest.groovy +++ b/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/ProductControllerTest.groovy @@ -81,7 +81,7 @@ class ProductControllerTest extends Specification { new Product().tap { challenges = [new Challenge()] } - ) + ) when: doReturn(mockResponse).when(productGateway).get(productId) @@ -133,7 +133,7 @@ class ProductControllerTest extends Specification { new Product().tap { challenges = [new Challenge()] } - ) + ) when: doReturn(mockResponse).when(productGateway).update(productId, product) @@ -169,7 +169,7 @@ class ProductControllerTest extends Specification { new Product().tap { challenges = [new Challenge()] } - ).withStatus(PathResponseStatus.OK) + ).withStatus(PathResponseStatus.OK) when: doReturn(mockResponse).when(productGateway).update(productId, product) @@ -188,7 +188,7 @@ class ProductControllerTest extends Specification { new Product().tap { challenges = [new Challenge()] } - ) + ) when: doReturn(mockResponse).when(productGateway).update(productId, product) @@ -252,7 +252,7 @@ class ProductControllerTest extends Specification { new Product().tap { challenges = [new Challenge()] } - ).withStatus(PathResponseStatus.OK) + ).withStatus(PathResponseStatus.OK) when: doReturn(mockResponse).when(productGateway).get(productId) diff --git a/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/ProfilesControllerTest.groovy b/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/ProfilesControllerTest.groovy index 3ea24fef..809df67c 100644 --- a/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/ProfilesControllerTest.groovy +++ b/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/ProfilesControllerTest.groovy @@ -218,7 +218,7 @@ class ProfilesControllerTest extends Specification { new ChallengeQuestions().tap { setChallenges(new MdxList().tap { add(new Challenge()) }) } - ) + ) doReturn(mockResponse).when(challengeQuestionGateway).update(any()) @@ -240,7 +240,7 @@ class ProfilesControllerTest extends Specification { setChallenges(new MdxList().tap { add(new Challenge()) }) setQuestionList(new Challenge()) } - ) + ) doReturn(mockResponse).when(securityQuestionGateway).update(any()) diff --git a/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/RecurringTransfersControllerTest.groovy b/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/RecurringTransfersControllerTest.groovy index bf342bc7..32833838 100644 --- a/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/RecurringTransfersControllerTest.groovy +++ b/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/RecurringTransfersControllerTest.groovy @@ -48,7 +48,7 @@ class RecurringTransfersControllerTest extends Specification implements WithMock new RecurringTransfer().tap { setChallenges(new MdxList().tap { add(new Challenge()) }) } - ) + ) when: Mockito.doReturn(mockResponse).when(recurringTransferGateway).create(transfer) @@ -147,7 +147,7 @@ class RecurringTransfersControllerTest extends Specification implements WithMock new RecurringTransfer().tap { setChallenges(new MdxList().tap { add(new Challenge()) }) } - ) + ) when: Mockito.doReturn(mockResponse).when(recurringTransferGateway).update("id", transfer) diff --git a/realtime/src/test/groovy/com/mx/path/service/connection/realtime/MdxRealtimeMembersConnectionTest.groovy b/realtime/src/test/groovy/com/mx/path/service/connection/realtime/MdxRealtimeMembersConnectionTest.groovy index 7cc13929..c20ff453 100644 --- a/realtime/src/test/groovy/com/mx/path/service/connection/realtime/MdxRealtimeMembersConnectionTest.groovy +++ b/realtime/src/test/groovy/com/mx/path/service/connection/realtime/MdxRealtimeMembersConnectionTest.groovy @@ -79,11 +79,11 @@ class MdxRealtimeMembersConnectionTest extends Mockery { expectConnection(withPath("/clientId/users/userId/members.json") .withMatcher { request -> return request.body == "{\n" + - " \"member\": {\n" + - " \"id\": \"memberId\",\n" + - " \"userkey\": \"userKey\"\n" + - " }\n" + - "}" + " \"member\": {\n" + + " \"id\": \"memberId\",\n" + + " \"userkey\": \"userKey\"\n" + + " }\n" + + "}" } ) .toRespond { request, response -> @@ -107,12 +107,12 @@ class MdxRealtimeMembersConnectionTest extends Mockery { expectConnection(withPath("/clientId/users/userId/members.json") .withMatcher { request -> return request.body == "{\n" + - " \"member\": {\n" + - " \"id\": \"memberId\",\n" + - " \"login\": \"login\",\n" + - " \"password\": \"abc\"\n" + - " }\n" + - "}" + " \"member\": {\n" + + " \"id\": \"memberId\",\n" + + " \"login\": \"login\",\n" + + " \"password\": \"abc\"\n" + + " }\n" + + "}" } ) .toRespond { request, response -> @@ -154,11 +154,11 @@ class MdxRealtimeMembersConnectionTest extends Mockery { expectConnection(withPath("/clientId/users/userId/members/memberId.json") .withMatcher { request -> return request.body == "{\n" + - " \"member\": {\n" + - " \"id\": \"memberId\",\n" + - " \"userkey\": \"newUserKey\"\n" + - " }\n" + - "}" + " \"member\": {\n" + + " \"id\": \"memberId\",\n" + + " \"userkey\": \"newUserKey\"\n" + + " }\n" + + "}" } ) .toRespond { request, response -> diff --git a/realtime/src/test/groovy/com/mx/path/service/connection/realtime/MdxRealtimeUsersConnectionTest.groovy b/realtime/src/test/groovy/com/mx/path/service/connection/realtime/MdxRealtimeUsersConnectionTest.groovy index 1d98024c..dc0cfb4b 100644 --- a/realtime/src/test/groovy/com/mx/path/service/connection/realtime/MdxRealtimeUsersConnectionTest.groovy +++ b/realtime/src/test/groovy/com/mx/path/service/connection/realtime/MdxRealtimeUsersConnectionTest.groovy @@ -78,14 +78,14 @@ class MdxRealtimeUsersConnectionTest extends Mockery { expectConnection(withPath("/clientId/users.json") .withMatcher {req -> return req.body == "{\n" + - " \"user\": {\n" + - " \"id\": \"userId\",\n" + - " \"email\": \"email\",\n" + - " \"first_name\": \"firstName\",\n" + - " \"last_name\": \"lastName\",\n" + - " \"phone\": \"phone\"\n" + - " }\n" + - "}" + " \"user\": {\n" + + " \"id\": \"userId\",\n" + + " \"email\": \"email\",\n" + + " \"first_name\": \"firstName\",\n" + + " \"last_name\": \"lastName\",\n" + + " \"phone\": \"phone\"\n" + + " }\n" + + "}" }) .toRespond { request, response -> response.withStatus(HttpStatus.OK)