fix(api): remove redundant null guard on squadNumber in PUT (#268)

nanotaboada · claude · nanotaboada · commit 0cd05af25d3d · 2026-04-06T18:13:57.000-03:00
Co-authored-by: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/main/java/ar/com/nanotaboada/java/samples/spring/boot/controllers/PlayersController.java b/src/main/java/ar/com/nanotaboada/java/samples/spring/boot/controllers/PlayersController.java
@@ -210,7 +210,7 @@ public ResponseEntity<List<PlayerDTO>> searchByLeague(@PathVariable String leagu
             @ApiResponse(responseCode = "404", description = "Not Found", content = @Content)
     })
     public ResponseEntity<Void> put(@PathVariable Integer squadNumber, @RequestBody @Valid PlayerDTO playerDTO) {
-        if (playerDTO.getSquadNumber() != null && !playerDTO.getSquadNumber().equals(squadNumber)) {
+        if (!playerDTO.getSquadNumber().equals(squadNumber)) {
             return ResponseEntity.status(HttpStatus.BAD_REQUEST).build();
         }
         playerDTO.setSquadNumber(squadNumber);

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ public ResponseEntity<List<PlayerDTO>> searchByLeague(@PathVariable String leagu`
`210`	`210`	`@ApiResponse(responseCode = "404", description = "Not Found", content = @Content)`
`211`	`211`	`})`
`212`	`212`	`public ResponseEntity<Void> put(@PathVariable Integer squadNumber, @RequestBody @Valid PlayerDTO playerDTO) {`
`213`		`- if (playerDTO.getSquadNumber() != null && !playerDTO.getSquadNumber().equals(squadNumber)) {`
	`213`	`+ if (!playerDTO.getSquadNumber().equals(squadNumber)) {`
`214`	`214`	`return ResponseEntity.status(HttpStatus.BAD_REQUEST).build();`
`215`	`215`	`}`
`216`	`216`	`playerDTO.setSquadNumber(squadNumber);`