Skip to content

Commit 3721876

Browse files
Copilotnbauma109
andauthored
Revert JetBrains test mock: use real network calls now that cloudfront.net is whitelisted
Agent-Logs-Url: https://github.com/nbauma109/setup-java/sessions/74ae64af-1192-420c-8c3e-aefa09bfb00a Co-authored-by: nbauma109 <9403560+nbauma109@users.noreply.github.com>
1 parent 7f63f5d commit 3721876

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

__tests__/distributors/jetbrains-installer.test.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import {HttpClient} from '@actions/http-client';
33
import {JetBrainsDistribution} from '../../src/distributions/jetbrains/installer';
44

55
import manifestData from '../data/jetbrains.json';
6+
import os from 'os';
67

78
describe('getAvailableVersions', () => {
89
let spyHttpClient: jest.SpyInstance;
9-
let spyHttpClientHead: jest.SpyInstance;
1010

1111
beforeEach(() => {
1212
spyHttpClient = jest.spyOn(HttpClient.prototype, 'getJson');
@@ -15,10 +15,6 @@ describe('getAvailableVersions', () => {
1515
headers: {},
1616
result: []
1717
});
18-
spyHttpClientHead = jest.spyOn(HttpClient.prototype, 'head');
19-
spyHttpClientHead.mockReturnValue({
20-
message: {statusCode: 200}
21-
});
2218
});
2319

2420
afterEach(() => {
@@ -44,8 +40,9 @@ describe('getAvailableVersions', () => {
4440
const availableVersions = await distribution['getAvailableVersions']();
4541
expect(availableVersions).not.toBeNull();
4642

47-
// manifestData items + 2 hidden versions (always included when head is mocked to return 200)
48-
expect(availableVersions.length).toBe(manifestData.length + 2);
43+
const length =
44+
os.platform() === 'win32' ? manifestData.length : manifestData.length + 2;
45+
expect(availableVersions.length).toBe(length);
4946
}, 10_000);
5047
});
5148

0 commit comments

Comments
 (0)