refactor: extract dashboard settings entry wrapper

Author: ndycode

lib/codex-manager/dashboard-settings-entry.ts

@@ -0,0 +1,57 @@
+import type { DashboardDisplaySettings } from "../dashboard-settings.js";
+
+export async function configureDashboardSettingsEntry(
+	currentSettings: DashboardDisplaySettings | undefined,
+	deps: {
+		configureDashboardSettingsController: (
+			currentSettings: DashboardDisplaySettings | undefined,
+			deps: {
+				loadDashboardDisplaySettings: () => Promise<DashboardDisplaySettings>;
+				promptSettings: (
+					settings: DashboardDisplaySettings,
+				) => Promise<DashboardDisplaySettings | null>;
+				settingsEqual: (
+					left: DashboardDisplaySettings,
+					right: DashboardDisplaySettings,
+				) => boolean;
+				persistSelection: (
+					selected: DashboardDisplaySettings,
+				) => Promise<DashboardDisplaySettings>;
+				applyUiThemeFromDashboardSettings: (
+					settings: DashboardDisplaySettings,
+				) => void;
+				isInteractive: () => boolean;
+				getDashboardSettingsPath: () => string;
+				writeLine: (message: string) => void;
+			},
+		) => Promise<DashboardDisplaySettings>;
+		loadDashboardDisplaySettings: () => Promise<DashboardDisplaySettings>;
+		promptSettings: (
+			settings: DashboardDisplaySettings,
+		) => Promise<DashboardDisplaySettings | null>;
+		settingsEqual: (
+			left: DashboardDisplaySettings,
+			right: DashboardDisplaySettings,
+		) => boolean;
+		persistSelection: (
+			selected: DashboardDisplaySettings,
+		) => Promise<DashboardDisplaySettings>;
+		applyUiThemeFromDashboardSettings: (
+			settings: DashboardDisplaySettings,
+		) => void;
+		isInteractive: () => boolean;
+		getDashboardSettingsPath: () => string;
+		writeLine: (message: string) => void;
+	},
+): Promise<DashboardDisplaySettings> {
+	return deps.configureDashboardSettingsController(currentSettings, {
+		loadDashboardDisplaySettings: deps.loadDashboardDisplaySettings,
+		promptSettings: deps.promptSettings,
+		settingsEqual: deps.settingsEqual,
+		persistSelection: deps.persistSelection,
+		applyUiThemeFromDashboardSettings: deps.applyUiThemeFromDashboardSettings,
+		isInteractive: deps.isInteractive,
+		getDashboardSettingsPath: deps.getDashboardSettingsPath,
+		writeLine: deps.writeLine,
+	});
+}

lib/codex-manager/settings-hub.ts

@@ -62,6 +62,7 @@ import {
 	cloneDashboardSettingsData,
 	dashboardSettingsDataEqual,
 } from "./dashboard-settings-data.js";
+import { configureDashboardSettingsEntry } from "./dashboard-settings-entry.js";
 import { promptExperimentalSettingsMenu } from "./experimental-settings-prompt.js";
 import {
 	getExperimentalSelectOptions,
@@ -477,7 +478,8 @@ async function promptDashboardDisplaySettings(
 async function configureDashboardDisplaySettings(
 	currentSettings?: DashboardDisplaySettings,
 ): Promise<DashboardDisplaySettings> {
-	return configureDashboardSettingsController(currentSettings, {
+	return configureDashboardSettingsEntry(currentSettings, {
+		configureDashboardSettingsController,
 		loadDashboardDisplaySettings,
 		promptSettings: promptDashboardDisplaySettings,
 		settingsEqual: dashboardSettingsEqual,
@@ -533,7 +535,8 @@ async function promptStatuslineSettings(
 async function configureStatuslineSettings(
 	currentSettings?: DashboardDisplaySettings,
 ): Promise<DashboardDisplaySettings> {
-	return configureDashboardSettingsController(currentSettings, {
+	return configureDashboardSettingsEntry(currentSettings, {
+		configureDashboardSettingsController,
 		loadDashboardDisplaySettings,
 		promptSettings: promptStatuslineSettings,
 		settingsEqual: dashboardSettingsEqual,

test/dashboard-settings-entry.test.ts

@@ -0,0 +1,26 @@
+import { describe, expect, it, vi } from "vitest";
+import { configureDashboardSettingsEntry } from "../lib/codex-manager/dashboard-settings-entry.js";
+
+describe("dashboard settings entry", () => {
+	it("delegates to dashboard settings controller with provided deps", async () => {
+		const configureDashboardSettingsController = vi.fn(async () => ({
+			menuShowStatusBadge: false,
+		}));
+		const result = await configureDashboardSettingsEntry(undefined, {
+			configureDashboardSettingsController,
+			loadDashboardDisplaySettings: vi.fn(async () => ({
+				menuShowStatusBadge: true,
+			})),
+			promptSettings: vi.fn(),
+			settingsEqual: vi.fn(() => false),
+			persistSelection: vi.fn(),
+			applyUiThemeFromDashboardSettings: vi.fn(),
+			isInteractive: vi.fn(() => true),
+			getDashboardSettingsPath: vi.fn(() => "/tmp/settings.json"),
+			writeLine: vi.fn(),
+		});
+
+		expect(configureDashboardSettingsController).toHaveBeenCalled();
+		expect(result).toEqual({ menuShowStatusBadge: false });
+	});
+});