fix: disable default rate-limit replay

Author: ndycode

lib/config.ts

@@ -166,9 +166,9 @@ export const DEFAULT_PLUGIN_CONFIG: PluginConfig = {
 	fastSession: false,
 	fastSessionStrategy: "hybrid",
 	fastSessionMaxInputItems: 30,
-	retryAllAccountsRateLimited: true,
+	retryAllAccountsRateLimited: false,
 	retryAllAccountsMaxWaitMs: 0,
-	retryAllAccountsMaxRetries: Infinity,
+	retryAllAccountsMaxRetries: 0,
 	unsupportedCodexPolicy: "strict",
 	fallbackOnUnsupportedCodexModel: false,
 	fallbackToGpt52OnUnsupportedGpt53: true,
@@ -873,7 +873,7 @@ export function getRetryAllAccountsRateLimited(
 	return resolveBooleanSetting(
 		"CODEX_AUTH_RETRY_ALL_RATE_LIMITED",
 		pluginConfig.retryAllAccountsRateLimited,
-		true,
+		false,
 	);
 }
 
@@ -894,7 +894,7 @@ export function getRetryAllAccountsMaxRetries(
 	return resolveNumberSetting(
 		"CODEX_AUTH_RETRY_ALL_MAX_RETRIES",
 		pluginConfig.retryAllAccountsMaxRetries,
-		Infinity,
+		0,
 		{ min: 0 },
 	);
 }

test/index-retry.test.ts

@@ -441,6 +441,42 @@ describe("OpenAIAuthPlugin rate-limit retry", () => {
 		expect(response.status).toBe(200);
 	});
 
+	it("does not replay across all accounts by default when every account is rate-limited", async () => {
+		delete process.env.CODEX_AUTH_RETRY_ALL_RATE_LIMITED;
+		delete process.env.CODEX_AUTH_RETRY_ALL_MAX_WAIT_MS;
+		delete process.env.CODEX_AUTH_RETRY_ALL_MAX_RETRIES;
+		vi.resetModules();
+
+		const { OpenAIAuthPlugin } = await import("../index.js");
+		const client = {
+			tui: { showToast: vi.fn() },
+			auth: { set: vi.fn() },
+		} as any;
+
+		const plugin = await OpenAIAuthPlugin({ client });
+
+		const getAuth = async () => ({
+			type: "oauth" as const,
+			access: "a",
+			refresh: "r",
+			expires: Date.now() + 60_000,
+			multiAccount: true,
+		});
+
+		const sdk = (await plugin.auth.loader(getAuth, { options: {}, models: {} })) as any;
+		const response = await sdk.fetch("https://example.com", {});
+		const payload = await response.json();
+
+		expect(globalThis.fetch).not.toHaveBeenCalled();
+		expect(response.status).toBe(429);
+		expect(payload).toEqual({
+			error: {
+				message:
+					"All 1 account(s) are rate-limited. Try again in 1000ms or add another account with `codex login`.",
+			},
+		});
+	});
+
 	it("rebuilds request headers after rotating to the next workspace", async () => {
 		const account = createMockAccount({
 			workspaces: [

test/plugin-config.test.ts

@@ -107,9 +107,9 @@ describe('Plugin Configuration', () => {
 				fastSession: false,
 				fastSessionStrategy: 'hybrid',
 				fastSessionMaxInputItems: 30,
-				retryAllAccountsRateLimited: true,
+				retryAllAccountsRateLimited: false,
 				retryAllAccountsMaxWaitMs: 0,
-				retryAllAccountsMaxRetries: Infinity,
+				retryAllAccountsMaxRetries: 0,
 				unsupportedCodexPolicy: 'strict',
 				fallbackOnUnsupportedCodexModel: false,
 				fallbackToGpt52OnUnsupportedGpt53: true,
@@ -167,9 +167,9 @@ describe('Plugin Configuration', () => {
 				fastSession: false,
 				fastSessionStrategy: 'hybrid',
 				fastSessionMaxInputItems: 30,
-				retryAllAccountsRateLimited: true,
+				retryAllAccountsRateLimited: false,
 				retryAllAccountsMaxWaitMs: 0,
-				retryAllAccountsMaxRetries: Infinity,
+				retryAllAccountsMaxRetries: 0,
 				unsupportedCodexPolicy: 'strict',
 				fallbackOnUnsupportedCodexModel: false,
 				fallbackToGpt52OnUnsupportedGpt53: true,
@@ -433,9 +433,9 @@ describe('Plugin Configuration', () => {
 				fastSession: false,
 				fastSessionStrategy: 'hybrid',
 				fastSessionMaxInputItems: 30,
-				retryAllAccountsRateLimited: true,
+				retryAllAccountsRateLimited: false,
 				retryAllAccountsMaxWaitMs: 0,
-				retryAllAccountsMaxRetries: Infinity,
+				retryAllAccountsMaxRetries: 0,
 				unsupportedCodexPolicy: 'strict',
 				fallbackOnUnsupportedCodexModel: false,
 				fallbackToGpt52OnUnsupportedGpt53: true,
@@ -499,9 +499,9 @@ describe('Plugin Configuration', () => {
 		fastSession: false,
 		fastSessionStrategy: 'hybrid',
 		fastSessionMaxInputItems: 30,
-		retryAllAccountsRateLimited: true,
+		retryAllAccountsRateLimited: false,
 		retryAllAccountsMaxWaitMs: 0,
-		retryAllAccountsMaxRetries: Infinity,
+		retryAllAccountsMaxRetries: 0,
 		unsupportedCodexPolicy: 'strict',
 		fallbackOnUnsupportedCodexModel: false,
 		fallbackToGpt52OnUnsupportedGpt53: true,
@@ -559,9 +559,9 @@ describe('Plugin Configuration', () => {
 			fastSession: false,
 			fastSessionStrategy: 'hybrid',
 			fastSessionMaxInputItems: 30,
-			retryAllAccountsRateLimited: true,
+			retryAllAccountsRateLimited: false,
 			retryAllAccountsMaxWaitMs: 0,
-			retryAllAccountsMaxRetries: Infinity,
+			retryAllAccountsMaxRetries: 0,
 			unsupportedCodexPolicy: 'strict',
 			fallbackOnUnsupportedCodexModel: false,
 			fallbackToGpt52OnUnsupportedGpt53: true,