refactor: drop unused pool lastUsed preservation

Author: ndycode

lib/runtime/account-pool.ts

@@ -16,7 +16,6 @@ export type TokenSuccessWithAccount = Extract<
 export async function persistAccountPoolResults(params: {
 	results: TokenSuccessWithAccount[];
 	replaceAll?: boolean;
-	preserveLastUsedOnUpdate?: boolean;
 	modelFamilies: readonly ModelFamily[];
 	withAccountStorageTransaction: <T>(
 		handler: (
@@ -32,11 +31,7 @@ export async function persistAccountPoolResults(params: {
 	) => string | undefined;
 	sanitizeEmail: (email: string | undefined) => string | undefined;
 }): Promise<void> {
-	const {
-		results,
-		replaceAll = false,
-		preserveLastUsedOnUpdate = false,
-	} = params;
+	const { results, replaceAll = false } = params;
 	if (results.length === 0) return;
 
 	await params.withAccountStorageTransaction(async (loadedStorage, persist) => {
@@ -166,9 +161,7 @@ export async function persistAccountPoolResults(params: {
 				refreshToken: result.refresh,
 				accessToken: result.access,
 				expiresAt: result.expires,
-				lastUsed: preserveLastUsedOnUpdate
-					? (existing.lastUsed ?? now)
-					: now,
+				lastUsed: now,
 				workspaces: mergedWorkspaces,
 				currentWorkspaceIndex: nextCurrentWorkspaceIndex,
 			};

test/account-pool.test.ts

@@ -52,122 +52,4 @@ describe("account pool helper", () => {
 			activeIndexByFamily: { codex: 0 },
 		});
 	});
-
-	it("advances lastUsed when updating an existing account by default", async () => {
-		const persist = vi.fn(async () => undefined);
-		const originalLastUsed = 456;
-		const nowSpy = vi.spyOn(Date, "now").mockReturnValue(789);
-
-		try {
-			await persistAccountPoolResults({
-				results: [
-					{
-						type: "success",
-						access: "access-token-next",
-						refresh: "refresh-token",
-						expires: 999,
-					},
-				],
-				replaceAll: false,
-				modelFamilies: ["codex"],
-				withAccountStorageTransaction: async (handler) =>
-					handler(
-						{
-							version: 3,
-							activeIndex: 0,
-							activeIndexByFamily: { codex: 0 },
-							accounts: [
-								{
-									accountId: "acct_1",
-									email: "user@example.com",
-									refreshToken: "refresh-token",
-									accessToken: "access-token-old",
-									expiresAt: 123,
-									addedAt: 111,
-									lastUsed: originalLastUsed,
-									enabled: true,
-								},
-							],
-						},
-						persist,
-					),
-				findMatchingAccountIndex: () => 0,
-				extractAccountId: () => "acct_1",
-				extractAccountEmail: () => "user@example.com",
-				sanitizeEmail: (email) => email,
-			});
-		} finally {
-			nowSpy.mockRestore();
-		}
-
-		expect(persist).toHaveBeenCalledWith(
-			expect.objectContaining({
-				accounts: [
-					expect.objectContaining({
-						refreshToken: "refresh-token",
-						accessToken: "access-token-next",
-						expiresAt: 999,
-						lastUsed: 789,
-					}),
-				],
-			}),
-		);
-	});
-
-	it("preserves lastUsed for report-style updates when requested", async () => {
-		const persist = vi.fn(async () => undefined);
-		const originalLastUsed = 456;
-
-		await persistAccountPoolResults({
-			results: [
-				{
-					type: "success",
-					access: "access-token-next",
-					refresh: "refresh-token",
-					expires: 999,
-				},
-			],
-			replaceAll: false,
-			preserveLastUsedOnUpdate: true,
-			modelFamilies: ["codex"],
-			withAccountStorageTransaction: async (handler) =>
-				handler(
-					{
-						version: 3,
-						activeIndex: 0,
-						activeIndexByFamily: { codex: 0 },
-						accounts: [
-							{
-								accountId: "acct_1",
-								email: "user@example.com",
-								refreshToken: "refresh-token",
-								accessToken: "access-token-old",
-								expiresAt: 123,
-								addedAt: 111,
-								lastUsed: originalLastUsed,
-								enabled: true,
-							},
-						],
-					},
-					persist,
-				),
-			findMatchingAccountIndex: () => 0,
-			extractAccountId: () => "acct_1",
-			extractAccountEmail: () => "user@example.com",
-			sanitizeEmail: (email) => email,
-		});
-
-		expect(persist).toHaveBeenCalledWith(
-			expect.objectContaining({
-				accounts: [
-					expect.objectContaining({
-						refreshToken: "refresh-token",
-						accessToken: "access-token-next",
-						expiresAt: 999,
-						lastUsed: originalLastUsed,
-					}),
-				],
-			}),
-		);
-	});
 });