fix: tighten stream budget accounting

Author: ndycode

index.ts

@@ -2170,6 +2170,14 @@ let sessionAffinityWriteVersion = 0;
 																continue;
 															}
 
+															if (
+																!tryConsumeOutboundRequestAttempt(
+																	"stream-failover",
+																	fallbackAccount.index,
+																)
+															) {
+																return null;
+															}
 															if (
 																!accountManager.consumeToken(
 																	fallbackAccount,
@@ -2179,14 +2187,6 @@ let sessionAffinityWriteVersion = 0;
 															) {
 																continue;
 															}
-															if (
-																!tryConsumeOutboundRequestAttempt(
-																	"stream-failover",
-																	fallbackAccount.index,
-																)
-															) {
-																return null;
-															}
 															fallbackAccount.accountId = fallbackAccountId;
 															if (
 																!hadFallbackAccountId &&

lib/request/request-attempt-budget.ts

@@ -15,14 +15,25 @@ export function computeOutboundRequestAttemptBudget(params: {
 	emptyResponseMaxRetries: number;
 	streamFailoverMax: number;
 }): number {
-	const accountCount = Math.max(1, Math.floor(params.accountCount));
+	const accountCount = Math.max(
+		1,
+		Math.floor(Number.isFinite(params.accountCount) ? params.accountCount : 1),
+	);
 	const maxSameAccountRetries = Math.max(
 		0,
-		Math.floor(params.maxSameAccountRetries),
+		Math.floor(
+			Number.isFinite(params.maxSameAccountRetries)
+				? params.maxSameAccountRetries
+				: 0,
+		),
 	);
 	const emptyResponseMaxRetries = Math.max(
 		0,
-		Math.floor(params.emptyResponseMaxRetries),
+		Math.floor(
+			Number.isFinite(params.emptyResponseMaxRetries)
+				? params.emptyResponseMaxRetries
+				: 0,
+		),
 	);
 	const streamFailoverMax = capStreamFailoverMax(params.streamFailoverMax);
 

test/request-attempt-budget.test.ts

@@ -23,6 +23,17 @@ describe("request attempt budget", () => {
 		).toBe(6);
 	});
 
+	it("sanitizes non-finite retry inputs to deterministic defaults", () => {
+		expect(
+			computeOutboundRequestAttemptBudget({
+				accountCount: Number.NaN,
+				maxSameAccountRetries: Number.POSITIVE_INFINITY,
+				emptyResponseMaxRetries: Number.NEGATIVE_INFINITY,
+				streamFailoverMax: Number.NaN,
+			}),
+		).toBe(1);
+	});
+
 	it("keeps the primary stream account plus at most one alternate", () => {
 		expect(
 			buildStreamFailoverCandidateOrder(2, [2, 5, 2, 7, 9]),