ObjectHelpers::getSuggestion() improved weights

Author: dg

src/Utils/ObjectHelpers.php

@@ -131,14 +131,14 @@ public static function getMagicProperties(string $class): array
 	 */
 	public static function getSuggestion(array $possibilities, string $value): ?string
 	{
-		$norm = preg_replace($re = '#^(get|set|has|is|add)(?=[A-Z])#', '', $value);
+		$norm = preg_replace($re = '#^(get|set|has|is|add)(?=[A-Z])#', '+', $value);
 		$best = null;
 		$min = (strlen($value) / 4 + 1) * 10 + .1;
 		foreach (array_unique($possibilities, SORT_REGULAR) as $item) {
 			$item = $item instanceof \Reflector ? $item->getName() : $item;
 			if ($item !== $value && (
 				($len = levenshtein($item, $value, 10, 11, 10)) < $min
-				|| ($len = levenshtein(preg_replace($re, '', $item), $norm, 10, 11, 10) + 20) < $min
+				|| ($len = levenshtein(preg_replace($re, '*', $item), $norm, 10, 11, 10)) < $min
 			)) {
 				$min = $len;
 				$best = $item;

tests/Utils/ObjectHelpers.getSuggestion().phpt

@@ -30,6 +30,11 @@ Assert::same(null, ObjectHelpers::getSuggestion(['setItem'], 'item'));
 Assert::same('setItem', ObjectHelpers::getSuggestion(['setItem'], 'Item'));
 Assert::same('setItem', ObjectHelpers::getSuggestion(['setItem'], 'addItem'));
 Assert::same(null, ObjectHelpers::getSuggestion(['addItem'], 'addItem'));
+Assert::same('set', ObjectHelpers::getSuggestion(['set'], 'get'));
+Assert::same('getA', ObjectHelpers::getSuggestion(['getA'], 'gtA'));
+Assert::same('trim', ObjectHelpers::getSuggestion([new ReflectionFunction('trim')], 'trm'));
+Assert::same('trim', ObjectHelpers::getSuggestion([new ReflectionFunction('trim')], 'getTrim'));
+Assert::same(null, ObjectHelpers::getSuggestion(['123'], 'x'));
 
 
 /*