Merge pull request #898 from nextcloud-libraries/chore/deprecate-selectors

Author: skjnldsv

CHANGELOG.md

@@ -6,6 +6,12 @@
 
 All notable changes to this project will be documented in this file.
 
+
+## v0.4.0 - UNRELEASED
+### Notes
+The Cypress selectors provided by the package are now deprecated and will be removed with the next release.
+Instead use role based selectors like `cy.findByRole` from `@testing-library/cypress`.
+
 ## v0.3.0 - 2025-10-14
 ### Added
 - feat: rename repository to e2e test server \([#758](https://github.com/nextcloud-libraries/nextcloud-e2e-test-server/pull/758)\)

__tests__/tsconfig.json

@@ -7,6 +7,8 @@
  * A Selector is a function that returns a cypress get or find chain.
  * You can pass an object to use its data and narrow down
  * tests against the various elements.
+ * 
+ * @deprecated - Use role based selectors instead (cy.findByRole, cy.findByLabelText, etc.)
  */
 export interface Selector {
 	(args?: Object): Cypress.Chainable<JQuery>

lib/selectors/index.ts

@@ -7,6 +7,15 @@ import type { Selector } from "."
 // This is a list of selectors for the @nextcloud/upload library
 // @see https://github.com/nextcloud/nextcloud-upload
 
+/**
+ * @deprecated - Use role based selectors instead (cy.findByRole, cy.findByLabelText, etc.)
+ */
 export const UploadPicker: Selector = () => cy.get('[data-cy-upload-picker]')
+/**
+ * @deprecated - Use role based selectors instead (cy.findByRole, cy.findByLabelText, etc.)
+ */
 export const UploadPickerInput: Selector = () => UploadPicker().find('[data-cy-upload-picker-input]')
+/**
+ * @deprecated - Use role based selectors instead (cy.findByRole, cy.findByLabelText, etc.)
+ */
 export const UploadPickerAddButton: Selector = () => UploadPicker().find('[data-cy-upload-picker-add]')