From f8897c5238a6e699fd81a999e7920f4f192cf240 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcel=20M=C3=BCller?= Date: Sun, 18 Oct 2026 23:53:11 +0200 Subject: [PATCH] fix: Remove auto increment migration on share_external MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Marcel Müller --- apps/files_sharing/appinfo/info.xml | 2 +- .../files_sharing/composer/composer/autoload_classmap.php | 2 +- apps/files_sharing/composer/composer/autoload_static.php | 2 +- ...51030081948.php => Version33000Date20251030081949.php} | 8 ++++++-- 4 files changed, 9 insertions(+), 5 deletions(-) rename apps/files_sharing/lib/Migration/{Version33000Date20251030081948.php => Version33000Date20251030081949.php} (79%) diff --git a/apps/files_sharing/appinfo/info.xml b/apps/files_sharing/appinfo/info.xml index a3830afa089e0..f64c2281ba941 100644 --- a/apps/files_sharing/appinfo/info.xml +++ b/apps/files_sharing/appinfo/info.xml @@ -14,7 +14,7 @@ Turning the feature off removes shared files and folders on the server for all share recipients, and also on the sync clients and mobile apps. More information is available in the Nextcloud Documentation. - 1.26.0 + 1.26.1 agpl Michael Gapczynski Bjoern Schiessle diff --git a/apps/files_sharing/composer/composer/autoload_classmap.php b/apps/files_sharing/composer/composer/autoload_classmap.php index 25596e2fe869b..1b8a3b62250d0 100644 --- a/apps/files_sharing/composer/composer/autoload_classmap.php +++ b/apps/files_sharing/composer/composer/autoload_classmap.php @@ -90,7 +90,7 @@ 'OCA\\Files_Sharing\\Migration\\Version24000Date20220404142216' => $baseDir . '/../lib/Migration/Version24000Date20220404142216.php', 'OCA\\Files_Sharing\\Migration\\Version31000Date20240821142813' => $baseDir . '/../lib/Migration/Version31000Date20240821142813.php', 'OCA\\Files_Sharing\\Migration\\Version32000Date20251017081948' => $baseDir . '/../lib/Migration/Version32000Date20251017081948.php', - 'OCA\\Files_Sharing\\Migration\\Version33000Date20251030081948' => $baseDir . '/../lib/Migration/Version33000Date20251030081948.php', + 'OCA\\Files_Sharing\\Migration\\Version33000Date20251030081949' => $baseDir . '/../lib/Migration/Version33000Date20251030081949.php', 'OCA\\Files_Sharing\\MountProvider' => $baseDir . '/../lib/MountProvider.php', 'OCA\\Files_Sharing\\Notification\\Listener' => $baseDir . '/../lib/Notification/Listener.php', 'OCA\\Files_Sharing\\Notification\\Notifier' => $baseDir . '/../lib/Notification/Notifier.php', diff --git a/apps/files_sharing/composer/composer/autoload_static.php b/apps/files_sharing/composer/composer/autoload_static.php index cab4306af2941..a067f7653576f 100644 --- a/apps/files_sharing/composer/composer/autoload_static.php +++ b/apps/files_sharing/composer/composer/autoload_static.php @@ -105,7 +105,7 @@ class ComposerStaticInitFiles_Sharing 'OCA\\Files_Sharing\\Migration\\Version24000Date20220404142216' => __DIR__ . '/..' . '/../lib/Migration/Version24000Date20220404142216.php', 'OCA\\Files_Sharing\\Migration\\Version31000Date20240821142813' => __DIR__ . '/..' . '/../lib/Migration/Version31000Date20240821142813.php', 'OCA\\Files_Sharing\\Migration\\Version32000Date20251017081948' => __DIR__ . '/..' . '/../lib/Migration/Version32000Date20251017081948.php', - 'OCA\\Files_Sharing\\Migration\\Version33000Date20251030081948' => __DIR__ . '/..' . '/../lib/Migration/Version33000Date20251030081948.php', + 'OCA\\Files_Sharing\\Migration\\Version33000Date20251030081949' => __DIR__ . '/..' . '/../lib/Migration/Version33000Date20251030081949.php', 'OCA\\Files_Sharing\\MountProvider' => __DIR__ . '/..' . '/../lib/MountProvider.php', 'OCA\\Files_Sharing\\Notification\\Listener' => __DIR__ . '/..' . '/../lib/Notification/Listener.php', 'OCA\\Files_Sharing\\Notification\\Notifier' => __DIR__ . '/..' . '/../lib/Notification/Notifier.php', diff --git a/apps/files_sharing/lib/Migration/Version33000Date20251030081948.php b/apps/files_sharing/lib/Migration/Version33000Date20251030081949.php similarity index 79% rename from apps/files_sharing/lib/Migration/Version33000Date20251030081948.php rename to apps/files_sharing/lib/Migration/Version33000Date20251030081949.php index ad69f6004121c..78e6bbdf42355 100644 --- a/apps/files_sharing/lib/Migration/Version33000Date20251030081948.php +++ b/apps/files_sharing/lib/Migration/Version33000Date20251030081949.php @@ -18,12 +18,16 @@ use Override; #[ModifyColumn(table: 'share_external', name: 'id', type: ColumnType::BIGINT, description: 'Remove auto-increment')] -class Version33000Date20251030081948 extends SimpleMigrationStep { +class Version33000Date20251030081949 extends SimpleMigrationStep { #[Override] public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper { /** @var ISchemaWrapper $schema */ $schema = $schemaClosure(); + $table = $schema->getTable('share_external'); + if (!$table->getColumn('id')->getAutoincrement()) { + return null; + } $schema->dropAutoincrementColumn('share_external', 'id'); - return null; + return $schema; } }