changes to CMake and bindings

Author: nick

.gitignore

@@ -3,3 +3,5 @@
 ################################################################################
 
 /.vs
+/.venv
+BUILDING.md

CMakeLists.txt

@@ -34,12 +34,10 @@ target_include_directories(docx_comment_parser
         $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
         $<INSTALL_INTERFACE:include>
     PRIVATE
-        
 )
 
 target_link_libraries(docx_comment_parser
     PRIVATE
-        
         ZLIB::ZLIB
 )
 
@@ -116,7 +114,6 @@ install(TARGETS docx_comment_parser
 install(FILES
     include/docx_comment_parser.h
     include/zip_reader.h
-    include/xml_utils.h
     DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/docx_comment_parser
 )
 

docx_comment_parser.h include/docx_comment_parser.hdocx_comment_parser.h renamed to include/docx_comment_parser.h

@@ -7,7 +7,7 @@
  *       -I$(python3 -c "import pybind11; print(pybind11.get_include())") \
  *       python_bindings.cpp ../src/docx_parser.cpp ../src/batch_parser.cpp \
  *       ../src/zip_reader.cpp \
- *       -lxml2 -lz \
+ *       -lz \
  *       -o docx_comment_parser$(python3-config --extension-suffix)
  *
  * Usage from Python:

xml_parser.h include/xml_parser.hxml_parser.h renamed to include/xml_parser.h

@@ -10,8 +10,6 @@
 """
 
 from setuptools import setup, Extension
-from setuptools.command.build_ext import build_ext
-import subprocess
 import sys
 import os
 
@@ -22,24 +20,26 @@
 except ImportError:
     raise RuntimeError("pybind11 not found. Install with: pip install pybind11")
 
-# ─── Locate libxml2 ───────────────────────────────────────────────────────────
-def pkg_config(*args):
-    try:
-        return subprocess.check_output(
-            ["pkg-config"] + list(args), stderr=subprocess.DEVNULL
-        ).decode().split()
-    except (subprocess.CalledProcessError, FileNotFoundError):
-        return []
-
-
-extra_compile_args = ["-std=c++17", "-O3", "-DNDEBUG",
+# ─── Platform-specific flags ─────────────────────────────────────────────────
+if sys.platform == "win32":
+    extra_compile_args = ["/std:c++17", "/O2", "/DNDEBUG", "/EHsc"]
+    extra_link_args    = []
+else:
+    extra_compile_args = [
+        "-std=c++17",
+        "-O3",
+        "-DNDEBUG",
+        "-fvisibility=hidden",
+    ]
+    extra_link_args = ["-lz"]
 
 # ─── Source files ─────────────────────────────────────────────────────────────
 sources = [
     "python/python_bindings.cpp",
     "src/docx_parser.cpp",
     "src/batch_parser.cpp",
     "src/zip_reader.cpp",
+    "src/xml_parser.cpp",
 ]
 
 ext = Extension(

zip_reader.h include/zip_reader.hzip_reader.h renamed to include/zip_reader.h

@@ -2,7 +2,6 @@
 
 #include <thread>
 #include <mutex>
-#include <atomic>
 #include <queue>
 #include <functional>
 #include <condition_variable>

python_bindings.cpp python/python_bindings.cpppython_bindings.cpp renamed to python/python_bindings.cpp

@@ -3,7 +3,6 @@
 #include "xml_parser.h"
 
 #include <algorithm>
-#include <cassert>
 #include <set>
 #include <unordered_map>
 #include <functional>

setup.py

@@ -26,7 +26,7 @@ static void decode_entities(const char* s, std::size_t len, std::string& out) {
     const char* end = s + len;
     while (s < end) {
         if (*s != '&') { out += *s++; continue; }
-        const char* amp = s++;
+        ++s; // skip '&'
         const char* semi = static_cast<const char*>(std::memchr(s, ';', static_cast<std::size_t>(end - s)));
         if (!semi) { out += '&'; continue; }
         std::string_view ref(s, static_cast<std::size_t>(semi - s));
@@ -65,7 +65,6 @@ static void decode_entities(const char* s, std::size_t len, std::string& out) {
             out += ';';
         }
         s = semi + 1;
-        (void)amp;
     }
 }
 
@@ -110,7 +109,7 @@ bool sax_parse(const char* data, std::size_t len, SaxHandler& h) {
     const char* end = data + len;
 
     // Reusable buffers to reduce allocations
-    std::string prefix, local, val, text_buf;
+    std::string prefix, local, text_buf;
 
     while (p < end) {
         if (*p != '<') {