Skip to content

Commit 1ea06f3

Browse files
committed
test: remove 16 18 nightly
Signed-off-by: Anton Whalley <anton@venshare.com>
1 parent 6e892bc commit 1ea06f3

2 files changed

Lines changed: 7 additions & 16 deletions

File tree

.github/workflows/push.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ jobs:
1919
- version: 10.x
2020
- version: 12.x
2121
- version: 14.x
22-
- version: 16.x
23-
- version: 18.x
24-
- version: 19.x
25-
mirror: https://nodejs.org/download/nightly
26-
- version: 19.x
27-
mirror: https://nodejs.org/download/v8-canary
22+
# - version: 16.x
23+
# - version: 18.x
24+
# - version: 19.x
25+
# mirror: https://nodejs.org/download/nightly
26+
# - version: 19.x
27+
# mirror: https://nodejs.org/download/v8-canary
2828
# os: [ubuntu-latest, macos-latest]
2929
# Temporarily disable MacOS until
3030
# https://github.com/nodejs/node/issues/32981 is fixed

test/common.js

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ SessionOutput.prototype.wait = function wait(regexp, callback, allLines) {
118118
const lines = [];
119119

120120
function onLine(line) {
121-
// console.log(line);
121+
122122
lines.push(line);
123123
if (self.session)
124124
debug(`[LINE][${self.session.lldb.pid}]`, line);
@@ -208,15 +208,6 @@ function Session(options) {
208208
this.stdout = new SessionOutput(this, this.lldb.stdout, timeout);
209209
this.stderr = new SessionOutput(this, this.lldb.stderr, timeout);
210210

211-
this.stderr.on('line', (line) => {
212-
console.log("stderrorline:" + line);
213-
});
214-
215-
this.stdout.on('line', (line) => {
216-
217-
});
218-
219-
220211
// Map these methods to stdout for compatibility with legacy tests.
221212
this.wait = SessionOutput.prototype.wait.bind(this.stdout);
222213
this.waitError = SessionOutput.prototype.wait.bind(this.stderr);

0 commit comments

Comments
 (0)