Skip to content

Commit 696b250

Browse files
kvakilNo9
authored andcommitted
Changes to postmortem data
1 parent 823196a commit 696b250

4 files changed

Lines changed: 10 additions & 6 deletions

File tree

src/llv8-constants.cc

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,11 @@ void Map::Load() {
9393
kMaybeConstructorOffset =
9494
LoadConstant("class_Map__constructor_or_backpointer__Object",
9595
"class_Map__constructor__Object");
96+
if (kMaybeConstructorOffset == -1) {
97+
kMaybeConstructorOffset =
98+
LoadConstant("class_Map__constructor_or_back_pointer__Object");
99+
}
100+
96101
kInstanceDescriptorsOffset = LoadConstant({
97102
"class_Map__instance_descriptors__DescriptorArray",
98103
"class_Map__instance_descriptors_offset",
@@ -300,7 +305,7 @@ void Context::Load() {
300305
void Script::Load() {
301306
kNameOffset = LoadConstant("class_Script__name__Object");
302307
kLineOffsetOffset = LoadConstant("class_Script__line_offset__SMI");
303-
kSourceOffset = LoadConstant("class_Script__source__Object");
308+
kSourceOffset = LoadConstant("class_Script__source__Object", 8);
304309
kLineEndsOffset = LoadConstant("class_Script__line_ends__Object");
305310
}
306311

src/llv8-inl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ inline CheckedType<int32_t> String::Length(Error& err) {
483483

484484
ACCESSOR(Script, Name, script()->kNameOffset, String)
485485
ACCESSOR(Script, LineOffset, script()->kLineOffsetOffset, Smi)
486-
ACCESSOR(Script, Source, script()->kSourceOffset, HeapObject)
486+
ACCESSOR(Script, Source, script()->kSourceOffset, String)
487487
ACCESSOR(Script, LineEnds, script()->kLineEndsOffset, HeapObject)
488488

489489
ACCESSOR(SharedFunctionInfo, function_data, shared_info()->kFunctionDataOffset,

src/llv8.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ void Script::GetLineColumnFromPos(int64_t pos, int64_t& line, int64_t& column,
484484
line = 0;
485485
column = 0;
486486

487-
HeapObject source = Source(err);
487+
String source = Source(err);
488488
if (err.Fail()) return;
489489

490490
int64_t type = source.GetType(err);
@@ -496,8 +496,7 @@ void Script::GetLineColumnFromPos(int64_t pos, int64_t& line, int64_t& column,
496496
return;
497497
}
498498

499-
String str(source);
500-
std::string source_str = str.ToString(err);
499+
std::string source_str = source.ToString(err);
501500
int64_t limit = source_str.length();
502501
if (limit > pos) limit = pos;
503502

src/llv8.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ class Script : public HeapObject {
182182

183183
inline String Name(Error& err);
184184
inline Smi LineOffset(Error& err);
185-
inline HeapObject Source(Error& err);
185+
inline String Source(Error& err);
186186
inline HeapObject LineEnds(Error& err);
187187

188188
void GetLines(uint64_t start_line, std::string lines[], uint64_t line_limit,

0 commit comments

Comments
 (0)