split tests to separate v10 sub tests

Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>

Author: bavulapati

implementors/node/features.js

@@ -7,3 +7,9 @@ globalThis.experimentalFeatures = {
   setPrototype: true,
   postFinalizer: true,
 };
+
+globalThis.napiVersion = Number(process.versions.napi);
+
+globalThis.skipTest = () => {
+  process.exit(0);
+};

implementors/node/process.js

@@ -6,19 +6,6 @@ import { listDirectoryEntries, runFileInSubprocess } from "./tests.ts";
 const ROOT_PATH = path.resolve(import.meta.dirname, "..", "..");
 const TESTS_ROOT_PATH = path.join(ROOT_PATH, "tests");
 
-const ASSERT_MODULE_PATH = path.join(
-  ROOT_PATH,
-  "implementors",
-  "node",
-  "assert.js"
-);
-const LOAD_ADDON_MODULE_PATH = path.join(
-  ROOT_PATH,
-  "implementors",
-  "node",
-  "load-addon.js"
-);
-
 async function populateSuite(
   testContext: TestContext,
   dir: string

implementors/node/run-tests.ts

@@ -34,12 +34,6 @@ const GC_MODULE_PATH = path.join(
   "node",
   "gc.js"
 );
-const PROCESS_MODULE_PATH = path.join(
-  ROOT_PATH,
-  "implementors",
-  "node",
-  "process.js"
-);
 const MUST_CALL_MODULE_PATH = path.join(
   ROOT_PATH,
   "implementors",
@@ -85,8 +79,6 @@ export function runFileInSubprocess(
         "--import",
         "file://" + GC_MODULE_PATH,
         "--import",
-        "file://" + PROCESS_MODULE_PATH,
-        "--import",
         "file://" + MUST_CALL_MODULE_PATH,
         filePath,
       ],

implementors/node/tests.ts

@@ -1,3 +1,6 @@
 add_node_api_cts_addon(test_string test_string.c test_null.c)
-# API like node_api_create_external_string_latin1 are available from NAPI_VERSION >= 10
-target_compile_definitions(test_string PRIVATE NAPI_VERSION=10)
+
+# APIs like node_api_create_external_string_latin1 and
+# node_api_create_property_key_utf8 are available from NAPI_VERSION >= 10
+add_node_api_cts_addon(test_string_v10 test_string_v10.c)
+target_compile_definitions(test_string_v10 PRIVATE NAPI_VERSION=10)

tests/js-native-api/test_string/CMakeLists.txt

@@ -1,12 +1,5 @@
 "use strict";
 
-// test_string addon requires Node-API version >= 10
-// (node_api_create_external_string_latin1/utf16).
-// Node-API 10 is supported in Node.js >= 22.14.0 and >= 23.6.0.
-if (Number(napiVersion) < 10) {
-  skipTest();
-}
-
 // Testing api calls for string
 const test_string = loadAddon("test_string");
 // The insufficient buffer test case allocates a buffer of size 4, including
@@ -44,10 +37,6 @@ const unicodeCases = [
 function testLatin1Cases(str) {
   assert.strictEqual(test_string.TestLatin1(str), str);
   assert.strictEqual(test_string.TestLatin1AutoLength(str), str);
-  assert.strictEqual(test_string.TestLatin1External(str), str);
-  assert.strictEqual(test_string.TestLatin1ExternalAutoLength(str), str);
-  assert.strictEqual(test_string.TestPropertyKeyLatin1(str), str);
-  assert.strictEqual(test_string.TestPropertyKeyLatin1AutoLength(str), str);
   assert.strictEqual(test_string.Latin1Length(str), str.length);
 
   if (str !== "") {
@@ -63,12 +52,6 @@ function testUnicodeCases(str, utf8Length, utf8InsufficientIdx) {
   assert.strictEqual(test_string.TestUtf16(str), str);
   assert.strictEqual(test_string.TestUtf8AutoLength(str), str);
   assert.strictEqual(test_string.TestUtf16AutoLength(str), str);
-  assert.strictEqual(test_string.TestUtf16External(str), str);
-  assert.strictEqual(test_string.TestUtf16ExternalAutoLength(str), str);
-  assert.strictEqual(test_string.TestPropertyKeyUtf8(str), str);
-  assert.strictEqual(test_string.TestPropertyKeyUtf8AutoLength(str), str);
-  assert.strictEqual(test_string.TestPropertyKeyUtf16(str), str);
-  assert.strictEqual(test_string.TestPropertyKeyUtf16AutoLength(str), str);
   assert.strictEqual(test_string.Utf8Length(str), utf8Length);
   assert.strictEqual(test_string.Utf16Length(str), str.length);
 

tests/js-native-api/test_string/test.js

@@ -1,12 +1,5 @@
 "use strict";
 
-// test_string addon requires Node-API version >= 10
-// (node_api_create_external_string_latin1/utf16).
-// Node-API 10 is supported in Node.js >= 22.14.0 and >= 23.6.0.
-if (Number(napiVersion) < 10) {
-  skipTest();
-}
-
 // Test passing NULL to object-related Node-APIs.
 const { testNull } = loadAddon("test_string");