refactor: move copyDirectory to own file for testability

Signed-off-by: David Sanders <dsanders11@ucsbalum.com>

Author: dsanders11

lib/copy-directory.js

@@ -0,0 +1,42 @@
+'strict'
+
+const { promises: fs } = require('graceful-fs')
+const path = require('path')
+
+const { backOff } = require('exponential-backoff')
+
+async function copyDirectory (src, dest, ensure = false) {
+  try {
+    await fs.stat(src)
+  } catch {
+    throw new Error(`Missing source directory for copy: ${src}`)
+  }
+  await fs.mkdir(dest, { recursive: true })
+  const entries = await fs.readdir(src, { withFileTypes: true })
+  for (const entry of entries) {
+    if (entry.isDirectory()) {
+      await copyDirectory(path.join(src, entry.name), path.join(dest, entry.name))
+    } else if (entry.isFile()) {
+      // with parallel installs, copying files may cause file errors on
+      // Windows so use an exponential backoff to resolve collisions
+      await backOff(async () => {
+        try {
+          await fs.copyFile(path.join(src, entry.name), path.join(dest, entry.name))
+        } catch (err) {
+          // if ensure, check if file already exists and that's good enough
+          if (ensure && err.code === 'EBUSY') {
+            try {
+              await fs.stat(path.join(dest, entry.name))
+              return
+            } catch {}
+          }
+          throw err
+        }
+      })
+    } else {
+      throw new Error('Unexpected file directory entry type')
+    }
+  }
+}
+
+module.exports = copyDirectory

lib/install.js

@@ -2,13 +2,13 @@
 
 const { createWriteStream, promises: fs } = require('graceful-fs')
 const os = require('os')
-const { backOff } = require('exponential-backoff')
 const tar = require('tar')
 const path = require('path')
 const { Transform, promises: { pipeline } } = require('stream')
 const crypto = require('crypto')
 const log = require('./log')
 const semver = require('semver')
+const copyDirectory = require('./copy-directory')
 const { download } = require('./download')
 const processRelease = require('./process-release')
 
@@ -119,40 +119,6 @@ async function install (gyp, argv) {
     }
   }
 
-  async function copyDirectory (src, dest) {
-    try {
-      await fs.stat(src)
-    } catch {
-      throw new Error(`Missing source directory for copy: ${src}`)
-    }
-    await fs.mkdir(dest, { recursive: true })
-    const entries = await fs.readdir(src, { withFileTypes: true })
-    for (const entry of entries) {
-      if (entry.isDirectory()) {
-        await copyDirectory(path.join(src, entry.name), path.join(dest, entry.name))
-      } else if (entry.isFile()) {
-        // with parallel installs, copying files may cause file errors on
-        // Windows so use an exponential backoff to resolve collisions
-        await backOff(async () => {
-          try {
-            await fs.copyFile(path.join(src, entry.name), path.join(dest, entry.name))
-          } catch (err) {
-            // if ensure, check if file already exists and that's good enough
-            if (gyp.opts.ensure && err.code === 'EBUSY') {
-              try {
-                await fs.stat(path.join(dest, entry.name))
-                return
-              } catch {}
-            }
-            throw err
-          }
-        })
-      } else {
-        throw new Error('Unexpected file directory entry type')
-      }
-    }
-  }
-
   async function go () {
     log.verbose('ensuring devDir is created', devDir)
 
@@ -277,7 +243,7 @@ async function install (gyp, argv) {
       }
 
       // copy over the files from the temp tarball extract directory to devDir
-      await copyDirectory(tarExtractDir, devDir)
+      await copyDirectory(tarExtractDir, devDir, gyp.opts.ensure)
     } finally {
       try {
         // try to cleanup temp dir