From bdf3547694f735d1c937f6140c9b05deec7d7057 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Wed, 26 Aug 2026 13:52:50 +0200 Subject: [PATCH 1/3] fix(ci): test on npm@12 Added a step to install npm version 12 globally in multiple job sections. --- .github/workflows/lint-commit.yml | 1 + .github/workflows/release-please.yml | 2 +- .github/workflows/tests.yml | 4 ++++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint-commit.yml b/.github/workflows/lint-commit.yml index d00b6590f8..ac665d31c0 100644 --- a/.github/workflows/lint-commit.yml +++ b/.github/workflows/lint-commit.yml @@ -18,6 +18,7 @@ jobs: - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: node-version: 22.x + - run: npm install --global npm@12 - run: npm install - name: Lint first PR commit message run: | diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index 83a6a99f94..c905b3e89f 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -43,5 +43,5 @@ jobs: with: node-version: lts/* registry-url: 'https://registry.npmjs.org' - - run: npm install npm@11 -g # Use npm@11 to publish with OIDC + - run: npm install npm@12 -g # Use npm@12 to publish with OIDC - run: npm publish --provenance --access public diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 20d9d8c74f..fc8e88abd0 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -39,6 +39,7 @@ jobs: uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: node-version: 22.x + - run: npm install --global npm@12 - name: Install Dependencies run: npm install - name: Lint @@ -56,6 +57,7 @@ jobs: uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: node-version: 22.x + - run: npm install --global npm@12 - name: Install Dependencies run: npm install - name: Check Engines @@ -77,6 +79,7 @@ jobs: uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: node-version: 22.x + - run: npm install --global npm@12 - name: Update npm run: | npm install npm@~11.10.0 -g # Workaround for https://github.com/npm/cli/issues/9151 @@ -135,6 +138,7 @@ jobs: uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: node-version: ${{ matrix.node }} + - run: npm install --global npm@12 - name: Use Python ${{ matrix.python }} uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0 with: From 702aadb626a68b3a09bb62268402de2a706d1553 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sun, 27 Sep 2026 20:40:53 +0200 Subject: [PATCH 2/3] Update tests.yml --- .github/workflows/tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index fc8e88abd0..ac033accdb 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -186,12 +186,12 @@ jobs: - name: Run Tests (macOS or Linux) if: runner.os != 'Windows' shell: bash - run: npm test --python="${pythonLocation}/python" + run: npm test env: FULL_TEST: ${{ (matrix.node == '26.x' && matrix.python == '3.14') && '1' || '0' }} - name: Run Tests (Windows) if: runner.os == 'Windows' - shell: bash # Building wasm on Windows requires using make generator, it only works in bash - run: npm run test --python="${pythonLocation}\\python.exe" + shell: bash # Building wasm on Windows requires using make generator; it only works in bash + run: npm run test env: FULL_TEST: ${{ (matrix.node == '26.x' && matrix.python == '3.14') && '1' || '0' }} From 8718baa78187d888ac759bce4a6e45c046c603df Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sun, 27 Sep 2026 21:02:31 +0200 Subject: [PATCH 3/3] Update Node test command in visual-studio.yml Removed python location parameter from Node test command. --- .github/workflows/visual-studio.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/visual-studio.yml b/.github/workflows/visual-studio.yml index 25c8d389d8..91d7fce95a 100644 --- a/.github/workflows/visual-studio.yml +++ b/.github/workflows/visual-studio.yml @@ -37,4 +37,4 @@ jobs: run: npm install - name: Run Node tests shell: pwsh - run: npm run test --python="${env:pythonLocation}\\python.exe" --msvs-version="${{ matrix.msvs-version }}" + run: npm run test --msvs-version="${{ matrix.msvs-version }}"