Skip to content

Commit 80d54b4

Browse files
XhmikosRMaledong
authored andcommitted
Tighten stylint config. (#2406)
1. Tighten stylint config. 2. Adhere to the stricter stylint rules.
1 parent 9705dab commit 80d54b4

11 files changed

Lines changed: 129 additions & 18 deletions

File tree

.stylintrc

Lines changed: 108 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,117 @@
11
{
2+
"blocks": false,
3+
"brackets": {
4+
"expect": false,
5+
"error": true
6+
},
27
"colons": {
38
"expect": "never",
49
"error": true
510
},
11+
"colors": false,
12+
"commaSpace": {
13+
"expect": "always",
14+
"error": true
15+
},
16+
"commentSpace": {
17+
"expect": "always",
18+
"error": true
19+
},
20+
"cssLiteral": {
21+
"expect": "never",
22+
"error": true
23+
},
24+
"depthLimit": false,
25+
"duplicates":{
26+
"expect": true,
27+
"error": true
28+
},
29+
"efficient": {
30+
"expect": "always",
31+
"error": true
32+
},
33+
"exclude": [],
34+
"extendPref": "@extends",
35+
"globalDupe": false,
36+
"groupOutputByFile": true,
637
"indentPref": {
738
"expect": 2,
839
"error": true
9-
}
40+
},
41+
"leadingZero": {
42+
"expect": "always",
43+
"error": true
44+
},
45+
"maxErrors": false,
46+
"maxWarnings": false,
47+
"mixed": {
48+
"expect": true,
49+
"error": true
50+
},
51+
"namingConvention": {
52+
"expect": "lowercase-dash",
53+
"error": true
54+
},
55+
"namingConventionStrict": {
56+
"expect": true,
57+
"error": true
58+
},
59+
"none": {
60+
"expect": "always",
61+
"error": true
62+
},
63+
"noImportant": false,
64+
"parenSpace": {
65+
"expect": "never",
66+
"error": true
67+
},
68+
"placeholders": {
69+
"expect": "always",
70+
"error": true
71+
},
72+
"prefixVarsWithDollar": {
73+
"expect": "always",
74+
"error": true
75+
},
76+
"quotePref": {
77+
"expect": "single",
78+
"error": true
79+
},
80+
"reporterOptions": {
81+
"columns": [
82+
"lineData",
83+
"severity",
84+
"description",
85+
"rule"
86+
],
87+
"columnSplitter": " ",
88+
"showHeaders": false,
89+
"truncate": true
90+
},
91+
"semicolons": {
92+
"expect": "never",
93+
"error": true
94+
},
95+
"sortOrder": false,
96+
"stackedProperties": {
97+
"expect": "never",
98+
"error": true
99+
},
100+
"trailingWhitespace": {
101+
"expect": "never",
102+
"error": true
103+
},
104+
"universal": {
105+
"expect": "never",
106+
"error": true
107+
},
108+
"valid": {
109+
"expect": true,
110+
"error": true
111+
},
112+
"zeroUnits": {
113+
"expect": "never",
114+
"error": true
115+
},
116+
"zIndexNormalize": false
10117
}

layouts/css/_base.styl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,5 +88,5 @@ blockquote
8888
top 0
8989
left 0
9090
background-color rgba(0, 0, 0, 0.14)
91-
content ""
91+
content ''
9292
display block

layouts/css/layout/_lists.styl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
+ li:before
99
content '|'
10-
padding 0 .3em 0 .1em
10+
padding 0 0.3em 0 0.1em
1111
color $light-gray
1212

1313
@media screen and (max-width: 480px)

layouts/css/layout/_sticky-footer.styl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Modernizr test for IE10 and IE11
22
// see: http://thatemil.com/blog/2013/11/03/sticky-footers-flexbox-and-ie10/
3-
.flexboxtweener
3+
.flexboxtweener,
44
.flexboxtweener body
55
height 100%
66

layouts/css/page-modules/_anchorLinks.styl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
.anchor
33
color $light-gray2
44
background none
5-
padding 0 .25em
5+
padding 0 0.25em
66

77
&:link
88
&:active

layouts/css/page-modules/_download.styl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
.download-header::after
1414
display block
1515
clear both
16-
content ""
16+
content ''
1717

1818
.download-hero
1919
margin-bottom 1em
@@ -99,7 +99,7 @@
9999
height 100%
100100
width 100%
101101
text-align center
102-
font-size 0.8em;
102+
font-size 0.8em
103103

104104
a:hover, a:active
105105
background $node-green
@@ -153,7 +153,7 @@ td.download-table-last
153153
flex-basis 160px
154154

155155
.tag
156-
font-size .6em
156+
font-size 0.6em
157157

158158
.download-matrix
159159
display block
@@ -168,13 +168,13 @@ td.download-table-last
168168

169169
td
170170
display block
171-
border 0
171+
border none
172172

173173
a
174174
text-align left
175175

176176
.download-table
177-
border 0
177+
border none
178178

179179
> thead
180180
display none
@@ -217,4 +217,4 @@ td.download-table-last
217217
li
218218
font-size 1em
219219
.tag
220-
font-size .4em
220+
font-size 0.4em

layouts/css/page-modules/_header.styl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,13 @@ header
7979
header
8080
li
8181
$border-width = 14px
82-
padding-bottom 12px;
82+
padding-bottom 12px
8383

8484
&.active:after
8585
top 100%
8686
left 50%
8787
border solid transparent
88-
content " "
88+
content ' '
8989
height 0
9090
width 0
9191
position absolute
@@ -138,7 +138,7 @@ header
138138

139139
img
140140
display block
141-
margin .5em auto 0 auto
141+
margin 0.5em auto 0
142142
border none
143143
max-height 75px
144144
max-width 180px

layouts/css/page-modules/_home.styl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242

4343
.home-banner
4444
opacity 1
45-
transition opacity .2s ease-in-out
45+
transition opacity 0.2s ease-in-out
4646

4747
&:hover
4848
opacity 0.85
@@ -65,7 +65,7 @@
6565
font-size 30px
6666
font-weight 400
6767

68-
transition background-color .2s ease-in-out
68+
transition background-color 0.2s ease-in-out
6969

7070
&:hover
7171
background-color $node-green

layouts/css/page-modules/_prev-next-navigation.styl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.btn-navigation
2-
padding .1em .5em
2+
padding 0.1em 0.5em
33

44
&.btn-prev
55
float left

layouts/css/page-modules/_scrollToTop.styl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
// For smooth scroll behavior
22
html
3+
// @stylint off
34
scroll-behavior smooth
5+
// @stylint on
46

57
#scroll-to-top
68
font-size 1rem

0 commit comments

Comments
 (0)