refactor: respect luacheck

Author: haorenW1025

lua/completion.lua

@@ -1,6 +1,5 @@
 local vim = vim
 local api = vim.api
-local util = require 'completion.util'
 local source = require 'source'
 local signature = require'completion.signature_help'
 local hover = require'completion.hover'
@@ -161,6 +160,7 @@ M.completionToggle = function()
   end
 end
 
+-- Deprecated
 M.customize_buf_label = function(label)
   api.nvim_buf_set_var(0, "completion_buf_customize_lsp_label", label)
 end

lua/completion/chain_completion.lua

@@ -37,7 +37,7 @@ local function chain_list_to_tree(complete_list)
   end
 end
 
-function getScopedChain(ft_subtree)
+local function getScopedChain(ft_subtree)
 
   local function syntaxGroupAtPoint()
     local pos = api.nvim_win_get_cursor(0)
@@ -112,7 +112,6 @@ function M.checkHealth(complete_items_map)
   if not error then
     health_ok("all completion source are valid")
   end
-  
 end
 
 return M

lua/completion/health.lua

@@ -5,7 +5,6 @@ local source = require'source'
 local health_start = vim.fn["health#report_start"]
 local health_ok = vim.fn['health#report_ok']
 local health_info = vim.fn['health#report_info']
-local health_warn = vim.fn['health#report_warn']
 local health_error = vim.fn['health#report_error']
 
 local M = {}

lua/completion/hover.lua

@@ -1,3 +1,4 @@
+-- define some hover related function modified from neovim source code
 local vim = vim
 local validate = vim.validate
 local api = vim.api
@@ -320,7 +321,6 @@ M.autoOpenHoverInPopup = function(manager)
         if user_data['hover'] ~= nil and type(user_data['hover']) == 'string' and #user_data['hover'] ~= 0 then
           local markdown_lines = vim.lsp.util.convert_input_to_markdown_lines(user_data['hover'])
           markdown_lines = vim.lsp.util.trim_empty_lines(markdown_lines)
-          local bufnr, winnr
           local position = vim.fn.pum_getpos()
           -- Set max width option to avoid overlapping with popup menu
           local total_column = api.nvim_get_option('columns')
@@ -330,7 +330,7 @@ M.autoOpenHoverInPopup = function(manager)
           else
             align = 'left'
           end
-          bufnr, winnr = fancy_floating_markdown(markdown_lines, {
+          local _, winnr = fancy_floating_markdown(markdown_lines, {
             pad_left = 1; pad_right = 1;
             col = position['col']; width = position['width']; row = position['row']-1;
             align = align
@@ -349,7 +349,6 @@ M.autoOpenHoverInPopup = function(manager)
           textDocument = vim.lsp.util.make_text_document_params();
           position = { line = row; character = col-1; }
         }
-        local winnr
         vim.lsp.buf_request(bufnr, 'textDocument/hover', params)
       end
       manager.textHover = false

lua/completion/signature_help.lua

@@ -81,8 +81,8 @@ function M.open_floating_preview(contents, filetype, opts)
   end
   api.nvim_buf_set_lines(floating_bufnr, 0, -1, true, contents)
   api.nvim_buf_set_option(floating_bufnr, 'modifiable', false)
-  api.nvim_command("autocmd CursorMovedI,BufHidden,TextChangedI,InsertLeave <buffer> ++once lua pcall(vim.api.nvim_win_close, "
-    ..floating_winnr..", true)")
+  api.nvim_command("autocmd CursorMovedI,BufHidden,TextChangedI,InsertLeave <buffer> ++once \
+    lua pcall(vim.api.nvim_win_close, "..floating_winnr..", true)")
   return floating_bufnr, floating_winnr
 end
 
@@ -124,7 +124,7 @@ local signature_help_to_preview_contents = function(input)
   return contents
 end
 
-M.autoOpenSignatureHelp = function(bufnr, line_to_cursor)
+M.autoOpenSignatureHelp = function()
   local bufnr = api.nvim_get_current_buf()
   local pos = api.nvim_win_get_cursor(0)
   local line = api.nvim_get_current_line()

lua/completion/util.lua

@@ -1,3 +1,7 @@
+------------------------------------------------------------------------
+--      utility function that are modified from neovim's source       --
+------------------------------------------------------------------------
+
 local protocol = require 'vim.lsp.protocol'
 local vim = vim
 local api = vim.api
@@ -7,9 +11,6 @@ function M.is_list(thing)
     return vim.fn.type(thing) == api.nvim_get_vvar("t_list")
 end
 
-------------------------------------------------------------------------
---      utility function that are modified from neovim's source       --
-------------------------------------------------------------------------
 
 ------------------------
 --  completion items  --
@@ -51,9 +52,6 @@ function M.text_document_completion_list_to_complete_items(result, prefix)
   end
 
   local customize_label = vim.g.completion_customize_lsp_label
-  local buf_customize_label = api.nvim_call_function(
-    'completion#get_buffer_variable', {'completion_buf_customize_lsp_label'})
-  if buf_customize_label == nil then buf_customize_label = {} end
   items = remove_unmatch_completion_items(items, prefix)
   -- sort_completion_items(items)
 
@@ -86,12 +84,12 @@ function M.text_document_completion_list_to_complete_items(result, prefix)
       table.insert(matches, {
         word = word,
         abbr = completion_item.label,
-        kind = buf_customize_label[kind] or customize_label[kind] or kind or '',
+        kind = customize_label[kind] or kind or '',
         menu = completion_item.detail or '',
         info = info,
         priority = priority,
         icase = 1,
-        user_data = vim.fn.json_encode(user_data),
+        user_data = user_data,
         dup = 1,
         empty = 1,
       })

lua/source.lua

@@ -35,7 +35,7 @@ M.stop_complete = false
 --                           local function                           --
 ------------------------------------------------------------------------
 
-local getTriggerCharacter = function(complete_source)
+local getTriggerCharacter = function()
   local triggerCharacter = {}
   local complete_source = M.chain_complete_list[M.chain_complete_index]
   if complete_source ~= nil and vim.fn.has_key(complete_source, "complete_items") > 0 then

lua/source/ins_complete.lua

@@ -50,7 +50,7 @@ M.triggerCompletion = function(manager, mode)
       checkEmptyCompletion(manager)
     end
   else
-    insertChar = false
+    manager.insertChar = false
   end
 end
 

lua/source/lsp.lua

@@ -13,7 +13,7 @@ M.getCallback = function()
   return M.callback
 end
 
-M.triggerFunction = function(prefix, _, bufnr, manager)
+M.triggerFunction = function(prefix, _, bufnr, _)
   local params = vim.lsp.util.make_position_params()
   M.callback = false
   M.items = {}

lua/source/path.lua

@@ -7,11 +7,7 @@ M.items = {}
 M.callback = false
 
 -- onDirScanned handler for vim.loop
-local function onDirScanned(err, data)
-  if err then
-    -- print('ERROR: ', err)
-    -- TODO handle err
-  end
+local function onDirScanned(_, data)
   if data then
     local function iter()
       return vim.loop.fs_scandir_next(data)
@@ -31,7 +27,7 @@ local fileTypesMap = setmetatable({
     ['block'] = "(block)",
     ['fifo'] = "(pipe)",
     ['socket'] = "(socket)"
-}, {__index = function() 
+}, {__index = function()
     return '(unknown)'
   end
 })
@@ -58,7 +54,7 @@ M.getCallback = function()
   return M.callback
 end
 
-M.triggerFunction = function(_, _, _, manager)
+M.triggerFunction = function()
   local pos = api.nvim_win_get_cursor(0)
   local line = api.nvim_get_current_line()
   local line_to_cursor = line:sub(1, pos[2])
@@ -83,9 +79,8 @@ M.triggerFunction = function(_, _, _, manager)
     end
   end
 
-  ::continue::
   M.items = {}
-  vim.loop.fs_scandir(path, onDirScanned)
+  loop.fs_scandir(path, onDirScanned)
 end
 
 return M