feat(#3310): minimum neovim version 0.10

Author: alex-courtis

CONTRIBUTING.md

@@ -132,10 +132,10 @@ Whenever new neovim API is introduced, please ensure that it is available in old
 See `nvim-tree.setup` for the oldest supported version of neovim. If the API is not availble in that version, a backwards compatibility shim must be used e.g.
 
 ```lua
-if vim.fn.has("nvim-0.10") == 1 then
-  modified = vim.api.nvim_get_option_value("modified", { buf = target_bufid })
+if vim.fn.has("nvim-0.11") == 1 and vim.hl and vim.hl.range then
+  vim.hl.range(0, ns_id, details.hl_group, { 0, col }, { 0, details.end_col, }, {})
 else
-  modified = vim.api.nvim_buf_get_option(target_bufid, "modified") ---@diagnostic disable-line: deprecated
+  vim.api.nvim_buf_add_highlight(0, ns_id, details.hl_group, 0, col, details.end_col) ---@diagnostic disable-line: deprecated
 end
 ```
 

lua/nvim-tree.lua

@@ -17,7 +17,7 @@ function M.setup(config_user)
   local view_state = require("nvim-tree.view-state")
 
   -- Nvim version check
-  if vim.fn.has("nvim-0.9") == 0 then
+  if vim.fn.has("nvim-0.10") == 0 then
     require("nvim-tree.notify").warn("nvim-tree.lua requires Neovim 0.9 or higher")
     return
   end

lua/nvim-tree/actions/node/system-open.lua

@@ -1,70 +1,9 @@
 local notify = require("nvim-tree.notify")
-local config = require("nvim-tree.config")
 
 local M = {}
 
 ---@param node Node
-local function user(node)
-  local cmd = config.g.system_open.cmd
-  local args = config.g.system_open.args
-
-  if #cmd == 0 then
-    if config.os.windows then
-      cmd = "cmd"
-      args = { "/c", "start", '""' }
-    elseif config.os.macos then
-      cmd = "open"
-    elseif config.os.unix then
-      cmd = "xdg-open"
-    end
-  end
-
-  if #cmd == 0 then
-    notify.warn("Cannot open file with system application. Unrecognized platform.")
-    return
-  end
-
-  local process = {
-    cmd = cmd,
-    args = args,
-    errors = "\n",
-    stderr = vim.loop.new_pipe(false),
-  }
-  table.insert(process.args, node.link_to or node.absolute_path)
-
-  local opts = {
-    args = process.args,
-    stdio = { nil, nil, process.stderr },
-    detached = true,
-  }
-
-  process.handle, process.pid = vim.loop.spawn(process.cmd, opts, function(code)
-    process.stderr:read_stop()
-    process.stderr:close()
-    process.handle:close()
-    if code ~= 0 then
-      notify.warn(string.format("system_open failed with return code %d: %s", code, process.errors))
-    end
-  end)
-
-  table.remove(process.args)
-  if not process.handle then
-    notify.warn(string.format("system_open failed to spawn command '%s': %s", process.cmd, process.pid))
-    return
-  end
-  vim.loop.read_start(process.stderr, function(err, data)
-    if err then
-      return
-    end
-    if data then
-      process.errors = process.errors .. data
-    end
-  end)
-  vim.loop.unref(process.handle)
-end
-
----@param node Node
-local function native(node)
+function M.fn(node)
   local _, err = vim.ui.open(node.link_to or node.absolute_path)
 
   -- err only provided on opener executable not found hence logging path is not useful
@@ -73,14 +12,4 @@ local function native(node)
   end
 end
 
----@param node Node
-function M.fn(node)
-  -- TODO #2430 always use native once 0.10 is the minimum neovim version
-  if vim.fn.has("nvim-0.10") == 1 and #config.g.system_open.cmd == 0 then
-    native(node)
-  else
-    user(node)
-  end
-end
-
 return M