fix lint errors and regenerate workflows

Author: herin049

.github/workflows/lint.yml

@@ -233,6 +233,25 @@ jobs:
       - name: Run tests
         run: tox -e lint-opentelemetry-exporter-otlp-proto-common
 
+  lint-opentelemetry-exporter-otlp-json-common:
+    name: opentelemetry-exporter-otlp-json-common
+    runs-on: ubuntu-latest
+    timeout-minutes: 30
+    steps:
+      - name: Checkout repo @ SHA - ${{ github.sha }}
+        uses: actions/checkout@v4
+
+      - name: Set up Python 3.14
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.14"
+
+      - name: Install tox
+        run: pip install tox-uv
+
+      - name: Run tests
+        run: tox -e lint-opentelemetry-exporter-otlp-json-common
+
   lint-opentelemetry-exporter-otlp-combined:
     name: opentelemetry-exporter-otlp-combined
     runs-on: ubuntu-latest

exporter/opentelemetry-exporter-otlp-json-common/benchmarks/test_benchmark_metrics_encoder.py

@@ -39,13 +39,17 @@ def test_benchmark_encode_gauge(benchmark):
 
 
 def test_benchmark_encode_histogram(benchmark):
-    data = make_metrics_data([
-        make_histogram(
-            exemplars=[
-                Exemplar({"sampled": "true"}, 298.0, TIME, SPAN_ID, TRACE_ID),
-            ],
-        )
-    ])
+    data = make_metrics_data(
+        [
+            make_histogram(
+                exemplars=[
+                    Exemplar(
+                        {"sampled": "true"}, 298.0, TIME, SPAN_ID, TRACE_ID
+                    ),
+                ],
+            )
+        ]
+    )
     benchmark(encode_metrics, data)
 
 
@@ -55,15 +59,19 @@ def test_benchmark_encode_exponential_histogram(benchmark):
 
 
 def test_benchmark_encode_mixed_metrics(benchmark):
-    data = make_metrics_data([
-        make_sum(name="counter"),
-        make_gauge(name="gauge"),
-        make_histogram(
-            name="histogram",
-            exemplars=[
-                Exemplar({"sampled": "true"}, 298.0, TIME, SPAN_ID, TRACE_ID),
-            ],
-        ),
-        make_exponential_histogram(name="exp_histogram"),
-    ])
+    data = make_metrics_data(
+        [
+            make_sum(name="counter"),
+            make_gauge(name="gauge"),
+            make_histogram(
+                name="histogram",
+                exemplars=[
+                    Exemplar(
+                        {"sampled": "true"}, 298.0, TIME, SPAN_ID, TRACE_ID
+                    ),
+                ],
+            ),
+            make_exponential_histogram(name="exp_histogram"),
+        ]
+    )
     benchmark(encode_metrics, data)

exporter/opentelemetry-exporter-otlp-json-common/benchmarks/test_benchmark_trace_encoder.py

@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+# pylint: disable=protected-access
+
 import pytest
 
 from opentelemetry.exporter.otlp.json.common.trace_encoder import encode_spans
@@ -20,7 +22,6 @@
 from opentelemetry.sdk.util.instrumentation import InstrumentationScope
 from opentelemetry.trace import Link
 from opentelemetry.trace.status import Status, StatusCode
-
 from tests import BASE_TIME, TRACE_ID, make_span
 
 

exporter/opentelemetry-exporter-otlp-json-common/tests/__init__.py

@@ -97,8 +97,10 @@ def assert_proto_json_equal(
             len(obj_b),
             f"List length mismatch at {path}: {len(obj_a)} != {len(obj_b)}",
         )
-        for i, (item_a, item_b) in enumerate(zip(obj_a, obj_b)):
-            assert_proto_json_equal(test_case, item_a, item_b, f"{path}[{i}]")
+        for idx, (item_a, item_b) in enumerate(zip(obj_a, obj_b)):
+            assert_proto_json_equal(
+                test_case, item_a, item_b, f"{path}[{idx}]"
+            )
     elif _is_none_equivalent(obj_a, obj_b):
         pass
     else:
@@ -196,28 +198,28 @@ def make_log(
     context=None,
     limits=None,
 ):
-    kwargs = dict(
-        timestamp=timestamp,
-        observed_timestamp=observed_timestamp,
-        severity_text=severity_text,
-        severity_number=severity_number,
-        body=body,
-        attributes=attributes or {},
-        event_name=event_name,
-    )
+    kwargs = {
+        "timestamp": timestamp,
+        "observed_timestamp": observed_timestamp,
+        "severity_text": severity_text,
+        "severity_number": severity_number,
+        "body": body,
+        "attributes": attributes or {},
+        "event_name": event_name,
+    }
     if context is not None:
         kwargs["context"] = context
 
-    rw_kwargs = dict(
-        resource=resource or Resource({}),
-        instrumentation_scope=InstrumentationScope("test_scope", "1.0")
+    rkwargs = {
+        "resource": resource or Resource({}),
+        "instrumentation_scope": InstrumentationScope("test_scope", "1.0")
         if instrumentation_scope is _UNSET
         else instrumentation_scope,
-    )
+    }
     if limits is not None:
-        rw_kwargs["limits"] = limits
+        rkwargs["limits"] = limits
 
-    return ReadableLogRecord(LogRecord(**kwargs), **rw_kwargs)
+    return ReadableLogRecord(LogRecord(**kwargs), **rkwargs)
 
 
 # ---------------------------------------------------------------------------

exporter/opentelemetry-exporter-otlp-json-common/tests/test_log_encoder.py

@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+# pylint: disable=unsubscriptable-object
+
 import json
 import unittest
 
@@ -45,7 +47,6 @@
     TraceFlags,
     set_span_in_context,
 )
-
 from tests import (
     SPAN_ID,
     TIME,
@@ -238,6 +239,7 @@ def test_encode_log_grouping_by_resource(self):
         self.assertEqual(len(result.resource_logs), 2)
 
         groups = {}
+        # pylint: disable-next=not-an-iterable
         for rl in result.resource_logs:
             svc_val = rl.resource.attributes[0].value.string_value
             bodies = [

exporter/opentelemetry-exporter-otlp-json-common/tests/test_metrics_encoder.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# pylint: disable=protected-access
+# pylint: disable=protected-access,unsubscriptable-object
 
 import json
 import unittest
@@ -30,7 +30,6 @@
     Buckets,
     Metric,
 )
-
 from tests import (
     SPAN_ID,
     TIME,

exporter/opentelemetry-exporter-otlp-json-common/tests/test_proto_json_compatibility.py

@@ -61,7 +61,6 @@
 from opentelemetry.sdk.trace import Event, SpanContext
 from opentelemetry.sdk.util.instrumentation import InstrumentationScope
 from opentelemetry.trace import Link
-
 from tests import (
     BASE_TIME,
     PARENT_SPAN_ID,

exporter/opentelemetry-exporter-otlp-json-common/tests/test_trace_encoder.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# pylint: disable=protected-access
+# pylint: disable=protected-access,unsubscriptable-object
 
 import json
 import unittest
@@ -45,7 +45,6 @@
 from opentelemetry.trace import Link, SpanKind
 from opentelemetry.trace.span import TraceState
 from opentelemetry.trace.status import Status, StatusCode
-
 from tests import (
     BASE_TIME,
     PARENT_SPAN_ID,
@@ -61,6 +60,7 @@ def _get_span(result, rs_idx=0, ss_idx=0, s_idx=0):
     return result.resource_spans[rs_idx].scope_spans[ss_idx].spans[s_idx]
 
 
+# pylint: disable=too-many-public-methods
 class TestOTLPTraceEncoder(unittest.TestCase):
     def test_encode_single_span(self):
         span = make_span()
@@ -183,6 +183,7 @@ def test_encode_span_grouping_by_resource(self):
         self.assertEqual(len(result.resource_spans), 2)
 
         groups = {}
+        # pylint: disable-next=not-an-iterable
         for rs in result.resource_spans:
             svc_val = rs.resource.attributes[0].value.string_value
             span_names = [s.name for ss in rs.scope_spans for s in ss.spans]
@@ -339,14 +340,14 @@ def test_encode_spans_to_dict(self):
         result_dict = result.to_dict()
 
         self.assertIn("resourceSpans", result_dict)
-        s = result_dict["resourceSpans"][0]["scopeSpans"][0]["spans"][0]
-
-        self.assertIsInstance(s["traceId"], str)
-        self.assertEqual(len(s["traceId"]), 32)
-        self.assertIsInstance(s["spanId"], str)
-        self.assertEqual(len(s["spanId"]), 16)
-        self.assertIsInstance(s["startTimeUnixNano"], str)
-        self.assertIsInstance(s["endTimeUnixNano"], str)
+        sp = result_dict["resourceSpans"][0]["scopeSpans"][0]["spans"][0]
+
+        self.assertIsInstance(sp["traceId"], str)
+        self.assertEqual(len(sp["traceId"]), 32)
+        self.assertIsInstance(sp["spanId"], str)
+        self.assertEqual(len(sp["spanId"]), 16)
+        self.assertIsInstance(sp["startTimeUnixNano"], str)
+        self.assertIsInstance(sp["endTimeUnixNano"], str)
 
     def test_encode_spans_json_roundtrip(self):
         parent_ctx = SpanContext(TRACE_ID, PARENT_SPAN_ID, is_remote=True)