fix breaking change detection with deprecations

Author: apcha-oai

.github/workflows/detect-breaking-changes.yml

@@ -36,9 +36,7 @@ jobs:
 
       - name: Detect breaking changes
         run: |
-          # Try to check out previous versions of the breaking change detection script. This ensures that
-          # we still detect breaking changes when entire files and their tests are removed.
-          git checkout "${{ github.event.pull_request.base.sha }}" -- ./scripts/detect-breaking-changes 2>/dev/null || true
+          test -f ./scripts/detect-breaking-changes || { echo "Missing scripts/detect-breaking-changes"; exit 1; }
           ./scripts/detect-breaking-changes ${{ github.event.pull_request.base.sha }}
 
   agents_sdk:

pyproject.toml

@@ -101,7 +101,7 @@ typecheck = { chain = [
   "typecheck:pyright",
   "typecheck:mypy"
 ]}
-"typecheck:pyright" = "pyright"
+"typecheck:pyright" = "scripts/run-pyright"
 "typecheck:verify-types" = "pyright --verifytypes openai --ignoreexternal"
 "typecheck:mypy" = "mypy ."
 

scripts/detect-breaking-changes

@@ -21,4 +21,4 @@ done
 
 # Instead of running the tests, use the linter to check if an
 # older test is no longer compatible with the latest SDK.
-./scripts/lint
+PYRIGHT_PROJECT=scripts/pyrightconfig.breaking-changes.json ./scripts/lint

scripts/pyrightconfig.breaking-changes.json

@@ -0,0 +1,4 @@
+{
+  "extends": "../pyproject.toml",
+  "reportDeprecated": false
+}

scripts/run-pyright

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+cd "$(dirname "$0")/.."
+
+CONFIG=${PYRIGHT_PROJECT:-pyproject.toml}
+exec pyright -p "$CONFIG" "$@"