Skip to content

Commit 306c789

Browse files
authored
Success page update (#113)
- [x] Updated the "How to contribute" link (#108) - [x] Moved Feedback to app header (#104) - [x] Updated the "Search for device" icon
2 parents b17020a + f24ed79 commit 306c789

3 files changed

Lines changed: 17 additions & 6 deletions

File tree

openandroidinstaller/openandroidinstaller.py

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,10 @@ def __init__(self, state: AppState):
9797
)
9898

9999
# create the install view
100-
self.install_view = InstallView(on_confirm=self.to_next_view, state=self.state)
100+
self.install_view = InstallView(
101+
on_confirm=self.to_next_view,
102+
state=self.state,
103+
)
101104

102105
# create the final success view
103106
self.final_view = SuccessView(state=self.state)
@@ -247,6 +250,17 @@ def main(page: Page, test: bool = False, test_config: str = "sargo"):
247250
padding=15,
248251
tooltip="Frequently asked questions and encountered issues.",
249252
),
253+
Container(
254+
content=ElevatedButton(
255+
icon=icons.FEEDBACK_OUTLINED,
256+
text="Give feedback",
257+
on_click=lambda _: webbrowser.open(
258+
"https://openandroidinstaller.org/feedback.html"
259+
),
260+
),
261+
padding=15,
262+
tooltip="Give feedback about your experience with OpenAndroidInstaller",
263+
),
250264
Container(
251265
content=ElevatedButton(
252266
icon=icons.BUG_REPORT_OUTLINED,

openandroidinstaller/views/start_view.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ def build(self):
186186
FilledButton(
187187
"Search for device",
188188
on_click=self.search_devices,
189-
icon=icons.PHONE_ANDROID,
189+
icon=icons.DEVICES_OTHER_OUTLINED,
190190
expand=True,
191191
tooltip="Search for a connected device.",
192192
),

openandroidinstaller/views/success_view.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ def build(
3636
):
3737
def close_window(e):
3838
logger.success("Success! Close the window.")
39-
# open the feedback page
40-
feedback_url = "https://openandroidinstaller.org/feedback.html"
41-
webbrowser.open(feedback_url)
4239
# close the window
4340
self.page.window_close()
4441

@@ -47,7 +44,7 @@ def close_window(e):
4744
get_title("Installation completed successfully!"),
4845
]
4946
# right view main part
50-
contribute_link = "https://github.com/openandroidinstaller-dev/openandroidinstaller#contributing"
47+
contribute_link = "https://openandroidinstaller.org/#contribute"
5148
self.right_view.controls = [
5249
Text(
5350
"Now your devices boots into the new OS. Have fun with it!",

0 commit comments

Comments
 (0)