Add validation tests for existing configs

Author: tsterbak

openandroidinstaller/assets/configs/FP2.yaml

@@ -2,7 +2,6 @@ metadata:
   maintainer: Tobias Sterbak (tsterbak)
   devicename: Fairphone 2
   devicecode: FP2
-requirements:
 steps:
   unlock_bootloader:
   flash_recovery:

openandroidinstaller/assets/configs/a3y17lte.yaml

@@ -2,8 +2,6 @@ metadata:
   maintainer: Tobias Sterbak (tsterbak)
   devicename: Samsung Galaxy A3 (2017)
   devicecode: a3y17lte
-requirements:
-  - heimdall
 steps:
   unlock_bootloader:
   flash_recovery:

openandroidinstaller/assets/configs/a5xelte.yaml

@@ -2,8 +2,6 @@ metadata:
   maintainer: Tobias Sterbak (tsterbak)
   devicename: Samsung Galaxy A5 (2016)
   devicecode: a5xelte
-requirements:
-  - heimdall
 steps:
   unlock_bootloader:
   flash_recovery:

openandroidinstaller/assets/configs/sargo.yaml

@@ -2,7 +2,6 @@ metadata:
   maintainer: Tobias Sterbak (tsterbak)
   devicename: Pixel 3a
   devicecode: sargo 
-requirements:
 steps:
   unlock_bootloader:
     - title: "Unlock the bootloader"

openandroidinstaller/assets/configs/yuga.yaml

@@ -2,15 +2,14 @@ metadata:
   maintainer: Tobias Sterbak (tsterbak)
   devicename: Sony Xperia Z
   devicecode: yuga
-requirements:
 steps:
   unlock_bootloader:
     - title: "Unlock the bootloader"
       type: confirm_button
       content: As a first step, you need to unlock the bootloader of your device. On the device, dial *#*#7378423#*#* (*#*#SERVICE#*#*) to launch the service menu.
     - title: "Unlock the bootloader"
       type: confirm_button
-      content: Go to service info > configuration and check rooting status - you can only continue if it says 'Bootloader unlock allowed: Yes.'
+      content: Go to service info > configuration and check rooting status - you can only continue if it says 'Bootloader unlock allowed":" Yes.'
     - title: "Unlock the bootloader"
       type: confirm_button
       content: Connect the device to your PC via USB. And confirm to continue.

openandroidinstaller/installer_config.py

@@ -124,7 +124,6 @@ def validate_config(config: str) -> bool:
             "devicename": str,
             "devicecode": str,
         },
-        "requirements": schema.Or(None, []),
         "steps": {
             "unlock_bootloader": schema.Or(None, [step_schema]),
             "flash_recovery": [step_schema],

tests/conftest.py

@@ -0,0 +1,17 @@
+"""Test existing config files for schema."""
+
+import pytest
+import yaml
+from pathlib import Path
+from openandroidinstaller.installer_config import validate_config
+
+
+@pytest.mark.parametrize(
+    "config_path,valid",
+    [(path, True) for path in Path("openandroidinstaller/assets/configs").iterdir()],
+)
+def test_config(config_path: Path, valid: bool):
+    """Test if the exisitng configs are valid."""
+    with open(config_path, "r") as stream:
+        raw_config = yaml.safe_load(stream)
+    assert valid == validate_config(raw_config)