Skip to content

Inconsistent transition animations in bottom navigation (Uploads compared to others) #207

Description

@pekvasnovsky

Android app from fossdroid v1.2.4

When navigating from "Personal" to "Shares" or the other way around the animation seems to be either quick or its just instant transition so effectively invisible/non-existent
But when navigating to/from "Uploads" the animation is visible and it is different from other transitions

This inconsistency I didn't seem to find in existing issues

At a glance it seems to be that there is a difference between the menu items

    private fun bottomBarNavigationTo(menuItemId: Int, isCurrentOptionActive: Boolean) {
        when (menuItemId) {
            R.id.nav_all_files -> navigateToOption(FileListOption.ALL_FILES)
            R.id.nav_spaces -> navigateToOption(FileListOption.SPACES_LIST)
            R.id.nav_uploads -> if (!isCurrentOptionActive) {
                val uploadListIntent = Intent(applicationContext, UploadListActivity::class.java)
                uploadListIntent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP)
                startActivity(uploadListIntent)
            }

            R.id.nav_available_offline_files -> navigateToOption(FileListOption.AV_OFFLINE)
            R.id.nav_shared_by_link_files -> navigateToOption(FileListOption.SHARED_BY_LINK)
        }
    }

I would assume to match the transitions, it would be enough just to change the activity transition to be instant or something similar, it then should match the rest

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions