Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

Commit 2282a38

Browse files
authored
Merge branch 'master' into farhanumar/psre-2485-1
2 parents 290f8fc + 399c8f0 commit 2282a38

12 files changed

Lines changed: 13 additions & 123 deletions

File tree

Makefile

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
dev.static dev.static.lms dev.static.studio dev.stats dev.status \
5757
dev.stop dev.up dev.up.attach dev.up.shell \
5858
dev.up.without-deps dev.up.without-deps.shell dev.up.with-programs \
59-
dev.up.with-watchers dev.validate docs e2e-tests e2e-tests.with-shell \
59+
dev.up.with-watchers dev.validate docs \
6060
help requirements impl-dev.clone.https impl-dev.clone.ssh impl-dev.provision \
6161
impl-dev.pull impl-dev.pull.without-deps impl-dev.up impl-dev.up.attach \
6262
impl-dev.up.without-deps selfcheck upgrade \
@@ -212,12 +212,8 @@ impl-dev.pull.%: ## Pull latest Docker images for services and their dependencie
212212
########################################################################################
213213

214214
impl-dev.provision: ## Provision dev environment with default services, and then stop them.
215-
# We provision all default services as well as 'e2e' (end-to-end tests).
216-
# e2e is not part of `DEFAULT_SERVICES` because it isn't a service;
217-
# it's just a way to tell ./provision.sh that the fake data for end-to-end
218-
# tests should be prepared.
219215
make dev.check-memory
220-
$(WINPTY) bash ./provision.sh $(DEFAULT_SERVICES)+e2e
216+
$(WINPTY) bash ./provision.sh $(DEFAULT_SERVICES)
221217
make dev.stop
222218

223219
dev.provision: ## Provision dev environment with default services, and then stop them.
@@ -604,12 +600,6 @@ metrics-opt-out: ## To opt out of metrics data collection
604600
docs: ## generate Sphinx HTML documentation, including API docs
605601
tox -e docs
606602

607-
e2e-tests: dev.up.lms+studio+firefox+chrome ## Run the end-to-end tests against the service containers.
608-
docker run -t --network=$(COMPOSE_PROJECT_NAME)_default -v $(DEVSTACK_WORKSPACE)/edx-e2e-tests:/edx-e2e-tests --env-file $(DEVSTACK_WORKSPACE)/edx-e2e-tests/devstack_env edxops/e2e env TERM=$(TERM) bash -c 'paver e2e_test'
609-
610-
e2e-tests.with-shell: dev.up.lms+studio+firefox+chrome ## Start the end-to-end tests container with a shell.
611-
docker run -it --network=$(COMPOSE_PROJECT_NAME)_default -v $(DEVSTACK_WORKSPACE)/edx-e2e-tests:/edx-e2e-tests --env-file $(DEVSTACK_WORKSPACE)/edx-e2e-tests/devstack_env edxops/e2e env TERM=$(TERM) bash
612-
613603
validate-lms-volume: ## Validate that changes to the local workspace are reflected in the LMS container.
614604
touch $(DEVSTACK_WORKSPACE)/edx-platform/testfile
615605
docker-compose exec -T lms ls /edx/app/edxapp/edx-platform/testfile

Makefile.edx

Lines changed: 0 additions & 34 deletions
This file was deleted.

compatibility.mk

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
.PHONY: backup check-memory destroy \
1515
dev.provision.services dev.repo.reset \
1616
dev.up.all dev.up.watchers down \
17-
e2e-shell healthchecks lms-restart \
17+
healthchecks lms-restart \
1818
lms-watcher-shell logs provision pull \
1919
pull.xqueue restore static stats stop stop.all \
2020
stop.watchers stop.xqueue studio-restart \
@@ -57,8 +57,6 @@ dev.up.watchers: dev.up.lms_watcher+studio_watcher
5757

5858
down: dev.down
5959

60-
e2e-shell: e2e-tests.with-shell
61-
6260
healthchecks: dev.check
6361

6462
lms-restart: dev.restart-devserver.lms

docker-compose.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ services:
2828
ports:
2929
- "15900:5900"
3030
volumes: # for file uploads
31-
- ../edx-e2e-tests/upload_files:/edx/app/e2e/edx-e2e-tests/upload_files
3231
- ../edx-platform/common/test/data:/edx/app/edxapp/edx-platform/common/test/data
3332

3433
coursegraph:
@@ -149,7 +148,6 @@ services:
149148
ports:
150149
- "25900:5900"
151150
volumes: # for file uploads
152-
- ../edx-e2e-tests/upload_files:/edx/app/e2e/edx-e2e-tests/upload_files
153151
- ../edx-platform/common/test/data:/edx/app/edxapp/edx-platform/common/test/data
154152

155153
# Events broker

docs/testing_and_debugging.rst

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -96,27 +96,4 @@ Most tests are run in Firefox by default. To use Chrome for tests that normally
9696
use Firefox instead, prefix the test command with
9797
``SELENIUM_BROWSER=chrome SELENIUM_HOST=edx.devstack.chrome``.
9898

99-
Running End-to-End Tests
100-
------------------------
101-
102-
To run the base set of end-to-end tests for edx-platform, run the following
103-
make target:
104-
105-
.. code:: sh
106-
107-
make e2e-tests
108-
109-
If you want to use some of the other testing options described in the
110-
`edx-e2e-tests README`_, you can instead start a shell for the e2e container
111-
and run the tests manually via paver:
112-
113-
.. code:: sh
114-
115-
make e2e-shell
116-
paver e2e_test
117-
118-
The browser running the tests can be seen and interacted with via VNC as
119-
described above (Firefox is used by default).
120-
12199
.. _edx-platform testing documentation: https://github.com/openedx/edx-platform/blob/master/docs/guides/testing/testing.rst#running-python-unit-tests
122-
.. _edx-e2e-tests README: https://github.com/edx/edx-e2e-tests/#how-to-run-lms-and-studio-tests

provision-e2e.sh

Lines changed: 0 additions & 24 deletions
This file was deleted.

provision.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ lms \
4242
ecommerce \
4343
discovery \
4444
credentials \
45-
e2e \
4645
forum \
4746
notes \
4847
registrar \

repo.sh

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ repos=(
2525
"https://github.com/openedx/credentials.git"
2626
"https://github.com/openedx/cs_comments_service.git"
2727
"https://github.com/openedx/ecommerce.git"
28-
"https://github.com/edx/edx-e2e-tests.git"
2928
"https://github.com/openedx/edx-notes-api.git"
3029
"https://github.com/openedx/edx-platform.git"
3130
"https://github.com/openedx/xqueue.git"
@@ -46,15 +45,14 @@ non_release_repos=(
4645
"https://github.com/openedx/frontend-app-program-console.git"
4746
"https://github.com/openedx/frontend-app-account.git"
4847
"https://github.com/openedx/frontend-app-profile.git"
49-
"https://github.com/edx/frontend-app-ora-grading.git"
48+
"https://github.com/openedx/frontend-app-ora-grading.git"
5049
)
5150

5251
ssh_repos=(
5352
"git@github.com:openedx/course-discovery.git"
5453
"git@github.com:openedx/credentials.git"
5554
"git@github.com:openedx/cs_comments_service.git"
5655
"git@github.com:openedx/ecommerce.git"
57-
"git@github.com:edx/edx-e2e-tests.git"
5856
"git@github.com:openedx/edx-notes-api.git"
5957
"git@github.com:openedx/edx-platform.git"
6058
"git@github.com:openedx/xqueue.git"
@@ -75,12 +73,7 @@ non_release_ssh_repos=(
7573
"git@github.com:openedx/frontend-app-program-console.git"
7674
"git@github.com:openedx/frontend-app-account.git"
7775
"git@github.com:openedx/frontend-app-profile.git"
78-
"git@github.com:edx/frontend-app-ora-grading.git"
79-
)
80-
81-
private_repos=(
82-
# Needed to run whitelabel tests.
83-
"https://github.com/edx/edx-themes.git"
76+
"git@github.com:openedx/frontend-app-ora-grading.git"
8477
)
8578

8679
if [ -n "${OPENEDX_RELEASE}" ]; then
@@ -184,11 +177,6 @@ clone_ssh ()
184177
_clone "${ssh_repos[@]}"
185178
}
186179

187-
clone_private ()
188-
{
189-
_clone "${private_repos[@]}"
190-
}
191-
192180
reset ()
193181
{
194182
read -p "This will switch to the default branch and pull changes in your local git checkouts. Would you like to proceed? [y/n] " -r
@@ -249,8 +237,6 @@ elif [ "$1" == "clone" ]; then
249237
clone
250238
elif [ "$1" == "clone_ssh" ]; then
251239
clone_ssh
252-
elif [ "$1" == "whitelabel" ]; then
253-
clone_private
254240
elif [ "$1" == "reset" ]; then
255241
reset
256242
elif [ "$1" == "status" ]; then

requirements/base.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ six==1.16.0
5959
# websocket-client
6060
texttable==1.6.7
6161
# via docker-compose
62-
urllib3==2.0.2
62+
urllib3==2.0.3
6363
# via
6464
# docker
6565
# requests

requirements/dev.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ exceptiongroup==1.1.1
7373
# via
7474
# -r requirements/test.txt
7575
# pytest
76-
filelock==3.12.0
76+
filelock==3.12.2
7777
# via
7878
# tox
7979
# virtualenv
@@ -109,7 +109,7 @@ pexpect==4.8.0
109109
# via -r requirements/test.txt
110110
pip-tools==6.13.0
111111
# via -r requirements/pip-tools.txt
112-
platformdirs==3.5.1
112+
platformdirs==3.5.3
113113
# via virtualenv
114114
pluggy==1.0.0
115115
# via
@@ -141,7 +141,7 @@ pyrsistent==0.19.3
141141
# -r requirements/base.txt
142142
# -r requirements/test.txt
143143
# jsonschema
144-
pytest==7.3.1
144+
pytest==7.3.2
145145
# via -r requirements/test.txt
146146
python-dotenv==0.21.1
147147
# via
@@ -187,7 +187,7 @@ tox==3.28.0
187187
# tox-battery
188188
tox-battery==0.6.1
189189
# via -r requirements/dev.in
190-
urllib3==2.0.2
190+
urllib3==2.0.3
191191
# via
192192
# -r requirements/base.txt
193193
# -r requirements/test.txt

0 commit comments

Comments
 (0)