Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

Commit e768331

Browse files
authored
feat: Remove redundant seed_permissions_roles call for demo course (#1142)
The `import` management command (from cms contentstore) is called right before the `seed_permissions_roles` command (from lms discussions). However, the import command already performs the seeding. See #1129 for archaeological notes. Confirmation that the call doesn't add anything: - Provisioned LMS with `DEVSTACK_SKIP_DEMO=true` - Manually ran first two commands for importing demo course (git clone, `import` management command) - Took MySQL DB dumps - Ran final demo course command, `seed_permissions_roles` - Took new DB dumps - Diff of SQL files showed only a change in the dump dates
1 parent b4d5523 commit e768331

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

provision-lms.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ then
5353
else
5454
docker-compose exec -T lms bash -e -c 'git clone https://github.com/openedx/edx-demo-course.git /tmp/edx-demo-course'
5555
docker-compose exec -T lms bash -e -c 'source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py cms --settings=devstack_docker import /edx/var/edxapp/data /tmp/edx-demo-course && rm -rf /tmp/edx-demo-course'
56-
# Seed forums for the demo course
57-
docker-compose exec -T lms bash -e -c "source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms --settings=devstack_docker seed_permissions_roles course-v1:edX+DemoX+Demo_Course"
5856
fi
5957

6058
demo_hashed_password='pbkdf2_sha256$20000$TjE34FJjc3vv$0B7GUmH8RwrOc/BvMoxjb5j8EgnWTt3sxorDANeF7Qw='

0 commit comments

Comments
 (0)